Closed daramousk closed 5 years ago
@gfcapalbo Sorry for that low quality commit, see updated one. I fixed some issues that I run through as well.
@gfcapalbo Have you seen these latest changes?
:+1: for me now, @hbrunn @NL66278 agreed?
@daramousk if you rebase while reviews are being done, diffs and changes become harder for reviewers. Squash at the end, easier to read diffs and understand whats happening without using memory.
please squash commits for merging
This PR has the approved
label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖
cc: @gfcapalbo