search

OCA / project-agile

30 stars 69 forks source link

[IMP] if get formview loaded with all use_scrum records load specific #20

Closed gfcapalbo closed 5 years ago

gfcapalbo commented 5 years ago

load specific scrum form when fetching use_scrum records.

hbrunn commented 5 years ago

codecov is right, a test would be nice. Please rebase afterwards

gfcapalbo commented 5 years ago

@hbrunn wrote simple test that covers the two extra code branches. rebased. waiting for CI results.

hbrunn commented 5 years ago

tests fail

rafaelbn commented 5 years ago

Hi @hbrunn could we merge this?

hbrunn commented 5 years ago

/ocabot merge patch

OCA-git-bot commented 5 years ago

What a great day to merge this nice PR. Let's do it! Prepared branch 10.0-ocabot-merge-pr-20-by-hbrunn-bump-patch, awaiting test results.

OCA-git-bot commented 5 years ago

@hbrunn your merge command was aborted due to failed check(s), which you can inspect on this commit of 10.0-ocabot-merge-pr-20-by-hbrunn-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

rafaelbn commented 5 years ago

/ocabot merge patch

OCA-git-bot commented 5 years ago

Sorry @rafaelbn you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

hbrunn commented 5 years ago

@gfcapalbo please add an extra commit where you update .travis.yml with the latest version from MQT to make this mergeable. Squash your commits while being at it

OCA-git-bot commented 5 years ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

rafaelbn commented 5 years ago

Hi @hbrunn @gfcapalbo next week this module will be migrated to v11, it could be great to have this merged :+1:

rafaelbn commented 5 years ago

Hi @hbrunn I think all is OK here. Could you retry merge?

hbrunn commented 5 years ago

/ocabot merge patch

OCA-git-bot commented 5 years ago

On my way to merge this fine PR! Prepared branch 10.0-ocabot-merge-pr-20-by-hbrunn-bump-patch, awaiting test results.

OCA-git-bot commented 5 years ago

@hbrunn your merge command was aborted due to failed check(s), which you can inspect on this commit of 10.0-ocabot-merge-pr-20-by-hbrunn-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

hbrunn commented 5 years ago

@gfcapalbo please rebase on current 10.0

hbrunn commented 5 years ago

actually, we need to update this branch's .travis.yml to the latest version from MQT, please add a commit that does that

hbrunn commented 5 years ago

/ocabot merge patch

OCA-git-bot commented 5 years ago

On my way to merge this fine PR! Prepared branch 10.0-ocabot-merge-pr-20-by-hbrunn-bump-patch, awaiting test results.

gfcapalbo commented 5 years ago

@hbrunn @rafaelbn added travis from mantainer quality tools , with python 2.7, all green. thank you.

OCA-git-bot commented 5 years ago

@hbrunn your merge command was aborted due to failed check(s), which you can inspect on this commit of 10.0-ocabot-merge-pr-20-by-hbrunn-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

hbrunn commented 5 years ago

/ocabot merge patch

OCA-git-bot commented 5 years ago

What a great day to merge this nice PR. Let's do it! Prepared branch 10.0-ocabot-merge-pr-20-by-hbrunn-bump-patch, awaiting test results.

OCA-git-bot commented 5 years ago

Congratulations, your PR was merged at 4515982df20a8956d7e44d6bc14ac730e21e5278. Thanks a lot for contributing to OCA. ❤️

rafaelbn commented 5 years ago

Great! @gfcapalbo @hbrunn you have already this module migrated to v11 ready to review :smile:

gfcapalbo commented 5 years ago

@rafaelbn thanks