search

OCA / project

Odoo Project Management and Services Company Addons
https://odoo-community.org/psc-teams/project-service-28
GNU Affero General Public License v3.0
275 stars 775 forks source link

[IMP] project_task_code: enable name search by Task Number #1246

Closed CLaurelB closed 6 months ago

CLaurelB commented 6 months ago

The search functionality has been improved to include the Task Number. This enhancement is achieved by inheriting the _name_search method to include the Task Number in the search domain.

The parent method adds the Name to the search domain (1). As a consequence of this action, when the args parameter is empty in the inherited method, an incomplete OR term must be added. Without this addition, the search domain would default to using an AND operator.

Additionally, tests have been added for this new inheritance.

(1) https://github.com/odoo/odoo/blob/4625cb2f/odoo/models.py#L1928

CLaurelB commented 6 months ago

@luisg123v could you review, please?

CLaurelB commented 6 months ago

Hello @pedrobaeza @yajo

Could you review, please?

Regards. cc. @moylop260 @luisg123v

OCA-git-bot commented 6 months ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot commented 6 months ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 15.0-ocabot-merge-pr-1246-by-yajo-bump-patch, awaiting test results.

OCA-git-bot commented 6 months ago

Congratulations, your PR was merged at 0efb5bffbd6a988414d5de8cf8e1a6e358fd025f. Thanks a lot for contributing to OCA. ❤️