[16.0][IMP] project_stock_product_set: Adapt wizard to changes in product_set

OCA / project

Odoo Project Management and Services Company Addons

https://odoo-community.org/psc-teams/project-service-28

GNU Affero General Public License v3.0

275 stars 775 forks source link

[16.0][IMP] project_stock_product_set: Adapt wizard to changes in product_set #1252

Closed pilarvargas-tecnativa closed 6 months ago

pilarvargas-tecnativa commented 6 months ago

Pending from:

[x] https://github.com/OCA/product-attribute/pull/1548

Moved some of the logic shared by the wizard defined in the module sale_product_set to the module product_set so the dependency of project_stock_product_set should now be on product_set.

cc @Tecnativa

@pedrobaeza @victoralmau please review

OCA-git-bot commented 6 months ago

Hi @victoralmau, some modules you are maintaining are being modified, check this out!

pilarvargas-tecnativa commented 6 months ago

In add_set, call always super, and don't add the self.check_partner() call.

:+1: thanks

pilarvargas-tecnativa commented 6 months ago

Remember to only take into account product type lines (avoid sections for example).

True, this was not taken into account before, it is already included in this module as well, thanks for reminding me.

OCA-git-bot commented 6 months ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 16.0-ocabot-merge-pr-1252-by-pedrobaeza-bump-major, awaiting test results.

OCA-git-bot commented 6 months ago

Congratulations, your PR was merged at 1950384af196c8aebc3aede4caf7c060fa5e9472. Thanks a lot for contributing to OCA. ❤️