OCA / project

Odoo Project Management and Services Company Addons
https://odoo-community.org/psc-teams/project-service-28
GNU Affero General Public License v3.0
275 stars 775 forks source link

[14.0][MIG] project_task_note: Migration to 14.0 #1310

Closed RogerSans closed 2 months ago

RogerSans commented 2 months ago

Standard migration T-6330

@HaraldPanten @ValentinVinagre

HaraldPanten commented 2 months ago

According this:

https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#commit-message

It wouldn't be a problem if you leave [MIG] in the commit message. But I have seen that other contributors have put [BCK] or similar and it has been accepted by other PSC.

@pedrobaeza @etobella We will remove the Odoo version, for sure, but which should be the "best" commit message extension when migrating a module, when we do it to older versions? IMHO we should keep [MIG].

THX in advance.

etobella commented 2 months ago

I don't have an strong opinion on this topic, but I would use [MIG]

pedrobaeza commented 2 months ago

Yes, [BCK] is not a valid tag, as you can see in the provided link. Some people in the community is not as strict as others and accept "anything" (even with debatable commit messages), but that shouldn't be if we want to have reliable homogeneity across whole community.

A migration commit is a migration commit, no matter if back or forward.

HaraldPanten commented 2 months ago

Thanks a lot, guys!

@RogerSans you'll have to delete the Odoo version, as @manuelregidor said, but you'll have to keep [MIG]; as it's the correct tag/extension for migrations.

pedrobaeza commented 2 months ago

Little joke: your login seems a True Type font :stuck_out_tongue_closed_eyes:

HaraldPanten commented 2 months ago

Little joke: your login seems a True Type font 😝

That's good, isn't it? 😃

RogerSans commented 2 months ago

Done. Sorry about that

manuelregidor commented 2 months ago

@RogerSans The commit name (not the PR title) is still not right. Could you have a look, please? Thank you.

etobella commented 2 months ago

/ocabot merge nobump

OCA-git-bot commented 2 months ago

On my way to merge this fine PR! Prepared branch 14.0-ocabot-merge-pr-1310-by-etobella-bump-nobump, awaiting test results.

OCA-git-bot commented 2 months ago

Congratulations, your PR was merged at 41f7205e7b93398a29ce60dec6332fff4f943206. Thanks a lot for contributing to OCA. ❤️