search

OCA / project

Odoo Project Management and Services Company Addons
https://odoo-community.org/psc-teams/project-service-28
GNU Affero General Public License v3.0
275 stars 775 forks source link

[14.0][ADD] project_milestone_estimated_hours #1332

Open abenzbiria opened 2 weeks ago

abenzbiria commented 2 weeks ago

Context

The module project_milestone <https://github.com/OCA/project/tree/14.0/project_milestone>_ allows to define milestones for a project.

Multiple tasks in the project can be linked to a given milestone.

Description

Field estimated hours is displayed in form and list view of a project milestone and in tab of milestones of a project. when a milestone is copied, value of estimated hours is copied too.

abenzbiria commented 2 weeks ago

Hi Hi @aleuffre , @leemannd , @OCA/project-service-maintainers

Could you review the code of this PR, please?

Have a nice day

TumbaoJu commented 5 days ago

@OCA/project-service-maintainers Hello! Can you please revise this PR? Thank you in advance.

rvalyi commented 2 days ago

nothing wrong in the code, but is it worth to add a full blown module just to add a single field? Wouldn't it be better to this field inside project_milestone directly instead?

cc @patrickrwilson @OCA/project-service-maintainers @pedrobaeza @dreispt

rvalyi commented 2 days ago

nothing wrong in the code, but is it worth to add a full blown module just to add a single field? Wouldn't it be better to this field inside project_milestone directly instead?

cc @patrickrwilson @OCA/project-service-maintainers @pedrobaeza @dreispt

actually after Odoo v15, project_milestone is removed from the OCA as it became a native feature. so not sure it's worth adding this module in v14. See https://github.com/OCA/project/pull/1268

TumbaoJu commented 2 days ago

nothing wrong in the code, but is it worth to add a full blown module just to add a single field? Wouldn't it be better to this field inside project_milestone directly instead? cc @patrickrwilson @OCA/project-service-maintainers @pedrobaeza @dreispt

actually after Odoo v15, project_milestone is removed from the OCA as it became a native feature. so not sure it's worth adding this module in v14. See #1268

I know that in V15, Odoo has included a feature for milestones but a lot of people use a V14 so, yes, I think it is worth it. But thank you for your comments. It is always good to have others thoughts about it.