OCA / project

Odoo Project Management and Services Company Addons
https://odoo-community.org/psc-teams/project-service-28
GNU Affero General Public License v3.0
278 stars 781 forks source link

Migration to version 15.0 #859

Open OCA-git-bot opened 3 years ago

OCA-git-bot commented 3 years ago

Todo

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-15.0

Modules to migrate

Missing module? Check https://github.com/OCA/maintainer-tools/wiki/%5BFAQ%5D-Missing-modules-in-migration-issue-list

georginacicerchia commented 2 years ago

Hello, as far as I could check, the functionalities of these two modules are now in Odoo: "project_task_dependency" and "project_timeline_task_dependency". Attached I left pictures, and the code could be checked here: https://github.com/odoo/odoo/tree/15.0/addons/project In particular, the mention to the task dependencies are here: https://github.com/odoo/odoo/blob/15.0/addons/project/models/project.py#L98

pedrobaeza commented 2 years ago

But that's for enterprise one. Probably the dependency module is not needed now as Odoo supports it, but the extension (or integrated in the main module project_timeline) is still needed for displaying in such view the dependencies.

georginacicerchia commented 2 years ago

But that's for enterprise one. Probably the dependency module is not needed now as Odoo supports it, but the extension (or integrated in the main module project_timeline) is still needed for displaying in such view the dependencies.

Rigth, my mistake, I checked the first one and file to check the second one. Summing up, "project_task_dependency" is now in odoo community

emagdalenaC2i commented 2 years ago

Migrating:

georginacicerchia commented 2 years ago

project_tag is now in odoo community https://github.com/odoo/odoo/blob/15.0/addons/project/models/project.py#L285 https://github.com/odoo/odoo/blob/15.0/addons/project/views/project_views.xml#L348

Mantux11 commented 2 years ago

I'll migrate project_milestone. But there is some questions. In Odoo 15.0 is project.milestone model, what to do with that? Also, there is some fields that matches original Odoo code. So what do you think about that? Thanks:) @OCA/project-service-maintainers

pedrobaeza commented 2 years ago

Isn't enough then with standard? The module as is doesn't make sense to be migrated. Maybe you can add a different extra module with some missing features in the standard.

gaikaz commented 2 years ago

Standard doesn't link tasks with milestones like OCA one does. So if someone is already using OCA module and it gets discontinued, migrating to v15 would mean loss of data. Even renaming here would be kind of tricky. How about we migrate the module with migration scripts that adapt OCA module fields to standard as close as possible, while keeping additional ones and the module name?

pedrobaeza commented 2 years ago

Why not creating then project_task_milestone with such feature and do the migration scripts/renaming in OpenUpgrade?

gaikaz commented 2 years ago

Sure thing. Tho, how would one rename a module in migration scripts? Is there a guide we could refer to? As I imagine, you would still make a dummy project_milestone module that just has the migration script with dependency for the new module?

Mantux11 commented 2 years ago

Also, I will migrate project.template until we decide what to do with project.milestone module.

pedrobaeza commented 2 years ago

Renames are managed in this file of OpenUpgrade: https://github.com/OCA/OpenUpgrade/blob/14.0/openupgrade_scripts/apriori.py

Mantux11 commented 2 years ago

project_template #887

Mantux11 commented 2 years ago

@pedrobaeza @gaikaz #888. I have created a PR with project_task_milestone module. Later I'll do migration scripts on project_milestone.

Mantux11 commented 2 years ago

@pedrobaeza @gaikaz I have created a PR #889 only with migration scripts. Everything is deleted and for later versions this module would not be migrated.

ghost commented 2 years ago

But that's for enterprise one. Probably the dependency module is not needed now as Odoo supports it, but the extension (or integrated in the main module project_timeline) is still needed for displaying in such view the dependencies.

Rigth, my mistake, I checked the first one and file to check the second one. Summing up, "project_task_dependency" is now in odoo community

Hi @georginacicerchia, you think that there is no need to migrate that module?

gaikaz commented 2 years ago

@georginacicerchia @BT-rfresco I suppose we do need to migrate the module, so that there is a migration script to adapt old data to standard. After that the module could be uninstalled. @OCA/project-service-maintainers Some input here would be really appreciated 🙂

bizzappdev commented 2 years ago

project_deadline #895

bizzappdev commented 2 years ago

project_task_material #898 project_stage_closed #897 project_role #896

bizzappdev commented 2 years ago

project_task_pull_request #900 project_task_code #899

georginacicerchia commented 2 years ago

But that's for enterprise one. Probably the dependency module is not needed now as Odoo supports it, but the extension (or integrated in the main module project_timeline) is still needed for displaying in such view the dependencies.

Rigth, my mistake, I checked the first one and file to check the second one. Summing up, "project_task_dependency" is now in odoo community

Hi @georginacicerchia, you think that there is no need to migrate that module?

Hi there, how are you? Odoo has include that function. Can't really say if technically there has to be a migration script, sorry :/

BT-aestebanez commented 2 years ago

But that's for enterprise one. Probably the dependency module is not needed now as Odoo supports it, but the extension (or integrated in the main module project_timeline) is still needed for displaying in such view the dependencies.

Rigth, my mistake, I checked the first one and file to check the second one. Summing up, "project_task_dependency" is now in odoo community

Hi @georginacicerchia, you think that there is no need to migrate that module?

Hi there, how are you? Odoo has include that function. Can't really say if technically there has to be a migration script, sorry :/

Yes, these two queries are needed:

UPDATE project_project SET allow_task_dependencies=true
WHERE id in (SELECT project_id FROM project_task WHERE id in (SELECT task_id FROM project_task_dependency_task_rel));

INSERT INTO task_dependencies_rel (task_id, depends_on_id)
SELECT task_id, dependency_task_id
FROM project_task_dependency_task_rel;

However, I don't know where this should be included. @pedrobaeza can you advice me, please?

Sources: https://github.com/odoo/odoo/blob/ff50844da0e4423372746e767f482a2a71148be4/addons/project/models/project.py#L994 and https://github.com/OCA/project/blob/8dbaeda24b6ea712baea8f191b2b124909b46c23/project_task_dependency/models/project_task.py#L12

gaikaz commented 2 years ago

@Mantux11 and me Might have forgotten to comment here, but module project_task_dependency is in PR (https://github.com/OCA/project/pull/892) for migration to v15. It only includes the migration script to move the data between the tables (just like @BT-aestebanez wrote). After that it can be uninstalled.

GongSiqiu commented 2 years ago

Will "Markdown On Project Tasks " be migrated?

sts-vaidehi commented 2 years ago

Migrating: project_department #932

vincent-hatakeyama commented 1 year ago

project_key #1055

Trivedi-Vacha-SerpentCS commented 1 year ago

project_timeline_task_dependency is missing to migrate?

pedrobaeza commented 1 year ago

Not needed anymore. Integrated into main module.

pedrobaeza commented 1 year ago

And I want to know the sense of life... I suppose nobody had interest on it.

tobehn commented 1 year ago

Is project_template_milestone migrated to 15.0i would need to have this feature in an Odoo 15.0 installation. Can i somehow help with the migration? Is there a guide how to migrate a module from 14.0to 15.0?

gaikaz commented 1 year ago

@tobehn Sorry, but no - that module is not migrated and I can't find it being migrated. The best start to do the migration on your own is to read this: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-15.0

tobehn commented 1 year ago

@gaikaz i have migrated the basics of this module. i can also install it in version 15.0 and if i create a project COPY from template it takes the names of the milestones and attaches tasks to the milestones as needed. Though it does not create the milestone_count and the milestones in the project.

can someone help with this?

It must have to do with this part in project.py of module _project_templatemilestone:

for new_task_record in project.task_ids:
            for new_milestone_record in project.milestone_ids:
                if new_task_record.milestone_id.name == new_milestone_record.name:
                    new_task_record.milestone_id = new_milestone_record.id
        return res

Or would copying the milestones needed to be integrated into the main module _projecttemplate

github-actions[bot] commented 10 months ago

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.

mymage commented 5 months ago

Hi all, I have a DB on 14.0 to migrate to 16.0 and I use project_category. Here I see that is "included in Odoo core" but I'm not able to find the same reference. I use project_category to strictly define the type of the project and I'm not sure that using tags is the same. Can someone give me some help to figure out the new way to do the same thing? Thanks

Edit Maybe I missed something or didn't understand: I find the module project_type which is the same as project_category. So it's not about "included in Odoo core" but about "renaming the module". Thanks for a confirmation

Edit 02/09/24 Confirmed in #1273