search

OCA / pylint-odoo

Odoo plugin for Pylint
http://www.pylint.org
143 stars 168 forks source link

Encountering unexpected W7936: Missing external dependency "odoo" from manifest #284

Closed TimLai125 closed 4 years ago

TimLai125 commented 4 years ago

The pre-commit command raises [W7936(missing-manifest-dependency), ] Missing external dependency "odoo" from manifest. More info: https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#external-dependencies after we update pre-commit to 2.5.1. https://travis-ci.com/github/qrtl/hls-custom/jobs/349626734#L707-L710

The isort.cfg already includes odoo: https://github.com/qrtl/hls-custom/blob/st2/.isort.cfg We suspect it maybe cause by the latest pre-commit version affects the pylint behavior and make the checking fails to identify odoo

I am not sure whether it is a related issue which is reported last year: https://github.com/OCA/pylint-odoo/issues/242

moylop260 commented 4 years ago

Hi @TimLai125 Thank you for reporting the issue and give us all steps and project to reproduce it.

It was fixed from

It was released in pylint-odoo==3.1.0

Last pylint-odoo==3.3.1:

You are using an old pylint-odoo==3.0.3:

Could you update your pylint-odoo version and check it again, please?

luisg123v commented 4 years ago

Hi @TimLai125,

Did you test the solution commented by @moylop260?

TimLai125 commented 4 years ago

@moylop260 Thank you for the suggestion, but we could not reproduce the issue now. We will update our pylint-odoo version anyways to avoid the same issue happens again. I am closing this issue for now.