search

OCA / pylint-odoo

Odoo plugin for Pylint
http://www.pylint.org
143 stars 168 forks source link

[ADD] pylint-odoo: add new check to maintainers key in manifest must be a list of str #308

Closed fernandahf closed 3 years ago

fernandahf commented 3 years ago

Description of the issue/feature this PR addresses:

Maintainers key in manifest must be a list of strings, according to https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/oca_module_lifecycle_maintainer_role.rst.

Current behavior before PR: Maintainers key is not check

Desired behavior after PR is merged: Maintainers check working and validating if it is a list of strings.

Fix #200

-- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

fernandahf commented 3 years ago

@moylop260

Could you review this, please?

fernandahf commented 3 years ago

@moylop260

Could you review this, please?

Regards.

moylop260 commented 3 years ago

@sbidoul

Could you check it again, please?

fernandahf commented 3 years ago

Hi @sbidoul

¿Could you check it again, please?

Regards.

OCA-git-bot commented 3 years ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖