[FIX] requirements: update min version pylint and isort

fernandahf commented 3 years ago

Description of the issue/feature this PR addresses:

pip 20.3 introduced a new dependency resolver that disallows having conflicting dependencies in the same environment. https://pip.pypa.io/en/stable/user_guide/?highlight=resolver#changes-to-the-pip-dependency-resolver-in-20-3-2020

As pylint-odoo requires pylint==2.5.3 (for python 3), a dependency conflict is easily obtained when trying to install it along with pylint:

conflict caused by: The user requested isort==4.3.21 pylint 2.6.0 depends on isort<6 and >=4.2.5 pylint-odoo 3.5.0 depends on isort==4.3.4

and

    The user requested pylint 2.6.0
    pylint-odoo 3.5.0 depends on pylint==2.5.3

This forces the use of an older pylint and isort version, which is not ideal.

Current behavior before PR: All checks working correct way.

Desired behavior after PR is merged: All checks working correct way without problems with dependencies.

Fix #306

-- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

fernandahf commented 3 years ago

@moylop260

Could you review this, please?

Regards.

moylop260 commented 3 years ago

Could you add a line in the .travis.yml to update pip, please?

I mean, something like


 install:
+     - pip install -U pip
      # Remove packages installed from addons-apt-packages of travis file
      - sed -i '/node/d' ${TRAVIS_BUILD_DIR}/install.sh
      - sed -i '/pip install ./d' ${TRAVIS_BUILD_DIR}/install.sh

fernandahf commented 3 years ago

Could you add a line in the .travis.yml to update pip, please?

I mean, something like

 install:
+     - pip install -U pip
      # Remove packages installed from addons-apt-packages of travis file
      - sed -i '/node/d' ${TRAVIS_BUILD_DIR}/install.sh
      - sed -i '/pip install ./d' ${TRAVIS_BUILD_DIR}/install.sh

@moylop260

Done

OCA / pylint-odoo

[FIX] requirements: update min version pylint and isort #313