search

OCA / queue

Asynchronous Job Queue
GNU Affero General Public License v3.0
183 stars 460 forks source link

[15.0][MIG] queue_job_batch, test_queue_job_batch: Migration to 15.0 #500

Closed amh-mw closed 1 year ago

amh-mw commented 1 year ago

@agenterp Since you noticed the lack of this module in the 15.0 milestone, mind giving it a review?

amh-mw commented 1 year ago

@jans23 Would you mind reviewing this pull request?

jans23 commented 1 year ago

Ok, will put it on our team's task list.

alihashaam commented 1 year ago

@amh-mw

There is a small issue with the way qweb is referenced in manifest file of queue_job_batch module of this PR.

as if you look in the base modules, it should be done as follow. This solved the error [1] for me as otherwise I was getting the error [1] that :

[1] Qweb template "queue_job_batch.view.Menu" not found

"assets": { "web.assets_qweb": [ "queue_job_batch/static/src/xml/systray.xml", ],

I would like to push this change but I dont have access to repo. How would you prefer I proceed?

alihashaam commented 1 year ago

@amh-mw

Please find our work in PR: https://github.com/amh-mw/queue/pull/1

@jans23 the module was also reviewed and two other small changes were included in above PR.

amh-mw commented 1 year ago

@alihashaam Thanks for the help!

github-actions[bot] commented 1 year ago

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

amh-mw commented 8 months ago

Reopened as #633