[16.0] queue_job: unify no delay option

OCA / queue

Asynchronous Job Queue

GNU Affero General Public License v3.0

179 stars 452 forks source link

[16.0] queue_job: unify no delay option #521

Closed simahawk closed 1 year ago

simahawk commented 1 year ago

Current situation:

multiple keys for no good reason
half baked: not all of them used everywhere
no centralization
poor naming

With this change we'll have:

1 and only one key to disable via ctx: queue_job__no_delay
1 and only one key to disable via os env: QUEUE_JOB__NO_DELAY
backward compatibility with deprecation for old keys

OCA-git-bot commented 1 year ago

Hi @guewen, some modules you are maintaining are being modified, check this out!

simahawk commented 1 year ago

Actually the env var has 2 underscores too. TBH this is just an approach I'm taking to identify keys by module especially if the are meant to be used in many many modules. So the __ is just to separate the name explicitly. I can change that of course.

guewen commented 1 year ago

/ocabot merge minor

OCA-git-bot commented 1 year ago

This PR looks fantastic, let's merge it! Prepared branch 16.0-ocabot-merge-pr-521-by-guewen-bump-minor, awaiting test results.

OCA-git-bot commented 1 year ago

Congratulations, your PR was merged at 216fe434b5075f14f1f6b2833584dcd8af73a9b5. Thanks a lot for contributing to OCA. ❤️