Closed guewen closed 1 year ago
This PR has the approved
label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖
/ocabot merge minor
I choose minor over patch because succeeding tests can now fail (these tests were not "correct" in the first place), there is no breaking change otherwise.
On my way to merge this fine PR! Prepared branch 14.0-ocabot-merge-pr-537-by-guewen-bump-minor, awaiting test results.
@guewen your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-537-by-guewen-bump-minor.
After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.
/ocabot merge minor
This PR looks fantastic, let's merge it! Prepared branch 14.0-ocabot-merge-pr-537-by-guewen-bump-minor, awaiting test results.
@guewen your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-537-by-guewen-bump-minor.
After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.
Oh, it fails because of https://github.com/odoo/odoo/commit/f0cab1bf847a851b355ff90292e332ba185d2a10
/ocabot merge minor
What a great day to merge this nice PR. Let's do it! Prepared branch 14.0-ocabot-merge-pr-537-by-guewen-bump-minor, awaiting test results.
Congratulations, your PR was merged at 03202fac7eed068159186ebd289523ec99763b45. Thanks a lot for contributing to OCA. ❤️
The trap_jobs() test helper accepts any model/recordset as long as the job function is the same, which is not enough to verify that the job has been delayed on the expected recordset or model.
Tested job functions are "bound methods" so we can (and should) compare their
__self__
.Example of assertion that would be valid:
Now, it would fail with an error message like: