search

OCA / queue

Asynchronous Job Queue
GNU Affero General Public License v3.0
183 stars 460 forks source link

[12.0][IMP] base_export_async: send mail using mail template #556

Closed paras-tsd closed 1 year ago

paras-tsd commented 1 year ago

module base_export_async: send mail using mail template for Asynchronous Export data

Backport of https://github.com/OCA/queue/commit/4a4ec05e2f7a3341a28b0dc3eca936623d810d1e

abhinavvaidya-tsd commented 1 year ago

Helo All,

Can someone take a look and merge this PR?

Best Regards, Abhinav

OCA-git-bot commented 1 year ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

abhinavvaidya-tsd commented 1 year ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Hi @simahawk @guewen,@sbidoul @ivantodorovich

Can someone please approve this PR?

Regards, Abhinav

StefanRijnhart commented 1 year ago

Across the OCA, there are too many PRs and not enough people doing reviews to review all PRs quickly (or even to review all PRs at any point). Please do some reviews yourself, not only in your own team :-) PRs on versions that are no longer supported by Odoo are the first victims of this reality.

As for the code itself, it's a backport of https://github.com/OCA/queue/pull/498/commits/4a4ec05e2f7a3341a28b0dc3eca936623d810d1e I see. Can you assign the original author as Co-authored-by in your commits? Also, please squash your commits.

StefanRijnhart commented 1 year ago

Thanks for the updates! One small thing: the co-author is not recognized by Github, or it would show both authors' avatars and names, as in this example: image

I think maybe you set the co-author by github username. Can you try assigning it in name <email> format? You can find Vincent's email in the git history.

paras-tsd commented 1 year ago

Hi,

@StefanRijnhart Thanks for your support, I have updated the git commit for Co-authored-by.

Regards, Paras Sutariya

simahawk commented 1 year ago

/ocabot merge minor

OCA-git-bot commented 1 year ago

This PR looks fantastic, let's merge it! Prepared branch 12.0-ocabot-merge-pr-556-by-simahawk-bump-minor, awaiting test results.

OCA-git-bot commented 1 year ago

Congratulations, your PR was merged at 217073078aefbc1419d55d33de9e28964a299938. Thanks a lot for contributing to OCA. ❤️