Closed nguyenminhchien closed 9 months ago
/ocabot migration queue_job
Please cherry-pick https://github.com/OCA/queue/commit/dafdf0a258808ad8a51fcbc9616a42d034549bac
In my opinion, everything is good, except maybe the method _patch_job_auto_delay, which should work in conjunction with the standard method _patch_method, which has been removed from the base model. For this module, it's not a big issue, but for example, the module test_queue_job won't work without _patch_method.
In my opinion, everything is good, except maybe the method _patch_job_auto_delay, which should work in conjunction with the standard method _patch_method, which has been removed from the base model. For this module, it's not a big issue, but for example, the module test_queue_job won't work without _patch_method.
@romi477 updated
Please cherry-pick dafdf0a
@MiquelRForgeFlow picked
/ocabot migration queue_job
I think you miss the 2nd commit from https://github.com/OCA/queue/pull/587 TIP: use oca-port to check that we do not miss any PR and finally get a blacklist of the PR that are ported already.
I think you miss the 2nd commit from #587 TIP: use oca-port to check that we do not miss any PR and finally get a blacklist of the PR that are ported already.
No, i didn't. it's here
@guewen could you please check it? (or somebody)
Please note that the following deprecation warning occurs in Odoo 17: DeprecationWarning: XML declarations in HTML module descriptions are deprecated since Odoo 17, queue_job can just have a UTF8 description with not need for a declaration.
Triggered by line 1 in queue_job/static/description/index.html
Please note that the following deprecation warning occurs in Odoo 17:
DeprecationWarning: XML declarations in HTML module descriptions are deprecated since Odoo 17, queue_job can just have a UTF8 description with not need for a declaration.
Triggered by line 1 in queue_job/static/description/index.html
fixed, tks.
Can it be merged? Or smth else is missing?
@guewen can we help somehow to finish migration of this module?
/ocabot merge nobump
What a great day to merge this nice PR. Let's do it! Prepared branch 17.0-ocabot-merge-pr-593-by-guewen-bump-nobump, awaiting test results.
Congratulations, your PR was merged at a70fda89c4583b2a4bbe272767a45dab4b18a369. Thanks a lot for contributing to OCA. ❤️
@pedrobaeza can you (or who is responsible?) publish it on Odoo App store?
Someone from board should do it.
I can have a look
/ocabot migration test_queue_job
Ref: BSRD-729