[17.0][MIG] queue_job + test_queue_job: Migration to 17.0

OCA / queue

Asynchronous Job Queue

GNU Affero General Public License v3.0

175 stars 451 forks source link

[17.0][MIG] queue_job + test_queue_job: Migration to 17.0 #593

Closed nguyenminhchien closed 9 months ago

nguyenminhchien commented 9 months ago

Ref: BSRD-729

pedrobaeza commented 9 months ago

/ocabot migration queue_job

MiquelRForgeFlow commented 9 months ago

Please cherry-pick https://github.com/OCA/queue/commit/dafdf0a258808ad8a51fcbc9616a42d034549bac

romi477 commented 9 months ago

In my opinion, everything is good, except maybe the method _patch_job_auto_delay, which should work in conjunction with the standard method _patch_method, which has been removed from the base model. For this module, it's not a big issue, but for example, the module test_queue_job won't work without _patch_method.

nguyenminhchien commented 9 months ago

In my opinion, everything is good, except maybe the method _patch_job_auto_delay, which should work in conjunction with the standard method _patch_method, which has been removed from the base model. For this module, it's not a big issue, but for example, the module test_queue_job won't work without _patch_method.

@romi477 updated

nguyenminhchien commented 9 months ago

Please cherry-pick dafdf0a

@MiquelRForgeFlow picked

gurneyalex commented 9 months ago

/ocabot migration queue_job

simahawk commented 9 months ago

I think you miss the 2nd commit from https://github.com/OCA/queue/pull/587 TIP: use oca-port to check that we do not miss any PR and finally get a blacklist of the PR that are ported already.

nguyenminhchien commented 9 months ago

I think you miss the 2nd commit from #587 TIP: use oca-port to check that we do not miss any PR and finally get a blacklist of the PR that are ported already.

No, i didn't. it's here

ventor-dev commented 9 months ago

@guewen could you please check it? (or somebody)

sanderlienaerts commented 9 months ago

Please note that the following deprecation warning occurs in Odoo 17: DeprecationWarning: XML declarations in HTML module descriptions are deprecated since Odoo 17, queue_job can just have a UTF8 description with not need for a declaration.

Triggered by line 1 in queue_job/static/description/index.html

nguyenminhchien commented 9 months ago

Please note that the following deprecation warning occurs in Odoo 17: DeprecationWarning: XML declarations in HTML module descriptions are deprecated since Odoo 17, queue_job can just have a UTF8 description with not need for a declaration.

Triggered by line 1 in queue_job/static/description/index.html

fixed, tks.

ventor-dev commented 9 months ago

Can it be merged? Or smth else is missing?