search

OCA / queue

Asynchronous Job Queue
GNU Affero General Public License v3.0
175 stars 451 forks source link

[FIX] queue_job: indicate job ID in failure message #601

Closed yajo closed 9 months ago

yajo commented 9 months ago

Failed queue jobs include a button to get to the job when received by email, added automatically by the mail.message_notification_email template.

However, when customers forward the email to their support team, they sometimes just copy and paste the error message. Or sometimes they don't have HTML edition available, so as to copy and paste the full mail and include the button.

Thus, it's simpler to just add the job ID to the failure notification. This way, it's easier for the support team to understand the source of the failure.

@moduon MT-3813 @rafaelbn @Shide

OCA-git-bot commented 9 months ago

Hi @guewen, some modules you are maintaining are being modified, check this out!

simahawk commented 9 months ago

wouldn't be better to use the UUID which is directly searchable in the UI?

guewen commented 9 months ago

Good idea on the principle but I would indeed output the uuid.

Shide commented 9 months ago

I'm agree with simahawk and guewen. It will be easy to read by a non-technical human

yajo commented 9 months ago

Thanks for your reviews! Changed.

guewen commented 9 months ago

/ocabot merge patch

OCA-git-bot commented 9 months ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 15.0-ocabot-merge-pr-601-by-guewen-bump-patch, awaiting test results.

OCA-git-bot commented 9 months ago

Congratulations, your PR was merged at 7b7aa5d958eea59c7766ad3242868a2ddd5cae08. Thanks a lot for contributing to OCA. ❤️