The latest test change breaks tests on Odoo.sh

OCA / queue

Asynchronous Job Queue

GNU Affero General Public License v3.0

175 stars 451 forks source link

The latest test change breaks tests on Odoo.sh #608

Open ventor-dev opened 8 months ago

ventor-dev commented 8 months ago

Module

Queue Job (queue_job)

Describe the bug

This commit leads to the errors with tests on Odoo.sh (check the screenshot below):

Looks like this can be easily fixed by removing doctests from this method (or at least removing new line added).

To Reproduce

Affected versions: 15.0.2.5.5, 16.0.2.5.5

Steps to reproduce the behavior:

Create new project on Odoo.sh
Add queue_job module
Wait until tests will be finished

Expected behavior No errors in tests

AlexanderPashuk commented 8 months ago

Prepared two PRs with hotfix for this issue. I suggest removing this doctest because it makes no sense (at least for me it is not obvious why there should be database with name "odoo" as result of this code).

I am willing to refactor this test case if needed but need more details about what we want to check while testing?

AlexanderPashuk commented 5 months ago

Hi all,

Prepared the same PR for 17.0 branch: https://github.com/OCA/queue/issues/608

@gurneyalex could you please merge them? They are the same as were done for 15.0 / 16.0

Thanks!