OCA / queue

Asynchronous Job Queue
GNU Affero General Public License v3.0
179 stars 456 forks source link

Fix for randomized retry interval format #624

Closed InigoGR closed 4 months ago

InigoGR commented 8 months ago

queue_job: fix retry format with tuple values

https://github.com/OCA/queue/pull/348 added support for randomized retry intervals. I could not set randomized retry intervals due to the formatting checks not being updated. This should fix it.

OCA-git-bot commented 8 months ago

Hi @guewen, some modules you are maintaining are being modified, check this out!

InigoGR commented 8 months ago

Thanks for your contrib! I guess it failed because we didn't have specific tests, right? Any chance you add that? If you don't have time that's fine, but it's a really nice to have if you can 😉

Also, could you please rewrite the commit msg to something like:

queue_job: fix retry format with tuple values

#348 added support for randomized retry intervals.
I could not set randomized retry intervals due to the formatting checks not being updated. This should fix it.

What changes:

  1. includes module name
  2. includes the full description of the issue

I will add test coverage for that case and change the commit message.

InigoGR commented 8 months ago

Added some simple tests that should cover the changes in _check_retry_pattern and _parse_retry_pattern.

OCA-git-bot commented 7 months ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

dreispt commented 5 months ago

@simahawk Is this good to merge?

dreispt commented 4 months ago

/ocabot merge patch

OCA-git-bot commented 4 months ago

On my way to merge this fine PR! Prepared branch 14.0-ocabot-merge-pr-624-by-dreispt-bump-patch, awaiting test results.

OCA-git-bot commented 4 months ago

Congratulations, your PR was merged at cf35a44277c63d70b84e6a7bd79cee138be0f5fe. Thanks a lot for contributing to OCA. ❤️