Closed AungKoKoLin1997 closed 5 months ago
This PR has the approved
label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖
/ocabot merge nobump
This PR looks fantastic, let's merge it! Prepared branch 16.0-ocabot-merge-pr-884-by-HviorForgeFlow-bump-nobump, awaiting test results.
Congratulations, your PR was merged at 0ad78fe75d19c3c1d61227c89619f68ba59d8077. Thanks a lot for contributing to OCA. ❤️
This module is designed to add encoding fields to the ir.actions.report model and is applied to text type reports.
This module was initially proposed in https://github.com/OCA/reporting-engine/pull/864, and
report_csv
depends on it. According to the discussion in this PR, this module should be used separately and specifically target text reports. Other modules (e.g.,report_xml
,report_csv
) have their own encoding fields, and adding this module as a dependency could disrupt existing installations.In this PR, I changed the module name from
report_format_option
toreport_text_format_option
to better reflect its primary focus on text report formatting. Additionally, I adjusted the encoding-related field names to avoid duplication with thereport_csv
encoding fields and to prevent breaking the UI.@qrtl