search

OCA / rest-framework

GNU Affero General Public License v3.0
307 stars 297 forks source link

[16.0] fastapi odoo module name is the same as the python module #400

Closed obayit closed 2 months ago

obayit commented 10 months ago

Module

fastapi

Describe the bug

The name of the odoo module is the same as the name of the python module fastapi.

Because of this, running odoo from the directory where the fastapi module exists, causes import error (this is common when naming a file or a directory with init.py the same name of an installed python module).

I hope that a note in the readme point this out to avoid confusion. Renaming the module is not an option, I think.

Can there be a check to warn about naming a module after one of its python dependencies?

To Reproduce

Run odoo instance with current working directory containing the fastapi module. An import error should appear when trying to install the module from the apps menu.

Steps to reproduce the behavior: Not applicable

Expected behavior Not applicable

Additional context Not applicable

lmignon commented 9 months ago

@obayit Thank you for the report. Indeed it's a common issue but not releated to this specific addon. A PR improving the documentation as suggested would be welcome.

github-actions[bot] commented 3 months ago

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.