search

OCA / rma

Odoo for Return Merchandise Authorization (RMA)
GNU Affero General Public License v3.0
78 stars 206 forks source link

[14.0][MIG] rma_delivery #332

Closed ghost closed 1 year ago

ghost commented 1 year ago

migration to 14.0: I had some problems with the pre-commit hooks: I had to comment out prettier otherwise it deletes the content of eg. res_config_settings_views.xml

Bildschirmfoto 2022-12-15 um 15 24 32

pedrobaeza commented 1 year ago

It's not correct to remove the prettier XML. Check that indentations in the XML are correct.

ghost commented 1 year ago

Thanks for the hint - there was one file which I didn't touch with intentation problems because of this file all xmls where deleted. Should work now, with the prettier config intact.

pedrobaeza commented 1 year ago

You must split the migration commit from the pre-commit changes.

OCA-git-bot commented 1 year ago

There's no issue in this repo with the title 'Migration to version 14.0' and the milestone 14.0, so not possible to add the comment.

pedrobaeza commented 1 year ago

/ocabot merge nobump

OCA-git-bot commented 1 year ago

This PR looks fantastic, let's merge it! Prepared branch 14.0-ocabot-merge-pr-332-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot commented 1 year ago

Congratulations, your PR was merged at 7123fbd51bf08e70aa7513942d78ca4fabd75e5c. Thanks a lot for contributing to OCA. ❤️