search

OCA / rma

Odoo for Return Merchandise Authorization (RMA)
GNU Affero General Public License v3.0
78 stars 206 forks source link

[13.0][FIX] rma: linked replacement moves #348

Closed chienandalu closed 1 year ago

chienandalu commented 1 year ago

It's useless to link the replacement moves and the side effect is that we can't make a proper reservation as the move stays in waiting state forever because the origin move (the reception one) is already done.

cc @Tecnativa TT42739

please review @victoralmau @pedrobaeza

OCA-git-bot commented 1 year ago

Hi @ernestotejeda, some modules you are maintaining are being modified, check this out!

chienandalu commented 1 year ago

I think the linked move should be for the return, not for the replacement.

Yes, it is: https://github.com/OCA/rma/blob/c0ad0bf6aae4f145dbe9c147fd8fc23c4e44dbd3/rma/models/rma.py#L1097

pedrobaeza commented 1 year ago

/ocabot merge patch

OCA-git-bot commented 1 year ago

On my way to merge this fine PR! Prepared branch 13.0-ocabot-merge-pr-348-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot commented 1 year ago

Congratulations, your PR was merged at 121b061e7228386906c6185d29a20415b7a2f105. Thanks a lot for contributing to OCA. ❤️

pedrobaeza commented 1 year ago

Please fw-port it

chienandalu commented 1 year ago

Looks like it's already addressed upstream