OCA / rma

Odoo for Return Merchandise Authorization (RMA)
GNU Affero General Public License v3.0
78 stars 206 forks source link

[16.0][FIX] rma: _get_sequence_values signature #366

Closed chienandalu closed 1 year ago

chienandalu commented 1 year ago

Respect the orignal method signature

https://github.com/odoo/odoo/blame/6bb68d9f3263c2154eb87ec22559d142e880c084/addons/stock/models/stock_warehouse.py#L1017

please review @pedrobaeza @victoralmau

cc @Tecnativa

OCA-git-bot commented 1 year ago

Hi @pedrobaeza, some modules you are maintaining are being modified, check this out!

pedrobaeza commented 1 year ago

I have noted that uninstalling the module, the sequences remain. Is there any cleanup code for that in standard?

chienandalu commented 1 year ago

I have noted that uninstalling the module, the sequences remain. Is there any cleanup code for that in standard?

Not that I'm aware of. I guess you don't even need to uninstall, but just remove a warehouse and that sequences dirt will stay there forever

pedrobaeza commented 1 year ago

hahaha: https://github.com/odoo/odoo/pull/134032

chienandalu commented 1 year ago

Oh :)

pedrobaeza commented 1 year ago

/ocabot merge patch

OCA-git-bot commented 1 year ago

This PR looks fantastic, let's merge it! Prepared branch 16.0-ocabot-merge-pr-366-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot commented 1 year ago

Congratulations, your PR was merged at 86e847b25149d1e3a326c5ee75a3ee8d152017ac. Thanks a lot for contributing to OCA. ❤️