[17.0][IMP] RMA - refactor to use procurement run

OCA / rma

Odoo for Return Merchandise Authorization (RMA)

GNU Affero General Public License v3.0

78 stars 206 forks source link

[17.0][IMP] RMA - refactor to use procurement run #397

Closed victoralmau closed 2 months ago

victoralmau commented 2 months ago

FWP from 16.0: https://github.com/OCA/rma/pull/402 + https://github.com/OCA/rma/pull/392

Extra changes:

Change reception_move_ids to reception_move_id
Add test_rma_replace_pick_ship
Code and method reduction to simplify logic
Set route_ids (in/out) from procurements

Please @pedrobaeza and @chienandalu can you review it?

@Tecnativa TT48789

OCA-git-bot commented 2 months ago

Hi @chienandalu, @pedrobaeza, some modules you are maintaining are being modified, check this out!

pedrobaeza commented 2 months ago

Testing in the runboat http://oca-rma-17-0-pr397-605691345d56.runboat.odoo-community.org to return a delivery order marking the RMA option, I get:

imagen

victoralmau commented 2 months ago

Reviewing the error you indicate, I see that it is a side effect of something that already happens currently in v17 and v16, if the user does NOT have the locations permission, the picking that is created does NOT have the correct data (location and picking_type_id).

This does not happen in tests because the user that is used does have this permission, I will review it to fix it.

OCA-git-bot commented 2 months ago

On my way to merge this fine PR! Prepared branch 17.0-ocabot-merge-pr-397-by-pedrobaeza-bump-major, awaiting test results.

OCA-git-bot commented 2 months ago

Congratulations, your PR was merged at 0ab50bd7f65ce57021b8d9dba43f6afc9a235ddc. Thanks a lot for contributing to OCA. ❤️