OCA / runbot-addons

Odoo Runbot Custom Features to be used by community.
https://odoo-community.org/project/community-maintainers-46
GNU Affero General Public License v3.0
28 stars 95 forks source link

[FIX] runbot_gitlab: Retrieve correctly SSH keys when under GitLab CI #178

Closed luisg123v closed 6 years ago

luisg123v commented 6 years ago

Currently, SSH keys are not retrieved correctly, due to a bad parsing of the HTTP response. When keys are retrieved from GitLab, the response's content is not a json, but a raw page; so it's raw bites, not str.

This commit parses correctly such responses, so SSH keys may be parsed correctly and SSH access may be granted.

This also causes empty authors to be skipped, they of course have neither username nor SSH keys, and retrieving them from GitLab would cause issues.