OCA / sale-reporting

GNU Affero General Public License v3.0
50 stars 193 forks source link

[16.0][MIG] sale_order_product_recommendation_product_sold_by_delivery_week: Migration to version 16.0 #221

Closed Yadier-Tecnativa closed 1 year ago

Yadier-Tecnativa commented 1 year ago

@tecnativa TT42433

Yadier-Tecnativa commented 1 year ago

@sergio-teruel , @chienandalu and @pedrobaeza please review test requirements.txt if I am missing something

pedrobaeza commented 1 year ago

/ocabot migration sale_order_product_recommendation_product_sold_by_delivery_week

sergio-teruel commented 1 year ago

@Yadier-Tecnativa sale_order_product_recommendation already merged, so remove the requirement commit. Thanks

sergio-teruel commented 1 year ago

ping @juangomezzurita

Yadier-Tecnativa commented 1 year ago

Done, pass all check except the runboat

pilarvargas-tecnativa commented 1 year ago

Check if the wizard layout looks correct.

image

Yadier-Tecnativa commented 1 year ago

Check if the wizard layout looks correct. @pilarvargas-tecnativa If you tried it locally, you should update the sale-workflow repo, since this problem comes from the view (sale_order_recommendation_view_form) and is corrected in the sale_order_product_recommendation module. Already the PR of sale_order_product_recommendation: Migration to version 16.0

2491 merged and from this one, which is dependent, the push was given again.

pilarvargas-tecnativa commented 1 year ago

Check if the wizard layout looks correct. @pilarvargas-tecnativa If you tried it locally, you should update the sale-workflow repo, since this problem comes from the view (sale_order_recommendation_view_form) and is corrected in the sale_order_product_recommendation module. Already the PR of sale_order_product_recommendation: Migration to version 16.0

2491 merged and from this one, which is dependent, the push was given again.

No, I did the test on the runboat of this PR, maybe it needs a rebase?

Yadier-Tecnativa commented 1 year ago

Done, (re-push)

pedrobaeza commented 1 year ago

/ocabot merge nobump

OCA-git-bot commented 1 year ago

This PR looks fantastic, let's merge it! Prepared branch 16.0-ocabot-merge-pr-221-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot commented 1 year ago

Congratulations, your PR was merged at 974d97521afa9181d44a096c662ded29542914c8. Thanks a lot for contributing to OCA. ❤️