OCA / sale-reporting

GNU Affero General Public License v3.0
50 stars 193 forks source link

[16.0][MIG] sale_layout_category_hide_detail: Migration to version 16.0 #222

Closed Yadier-Tecnativa closed 1 year ago

Yadier-Tecnativa commented 1 year ago

@Tecnativa TT43243

pedrobaeza commented 1 year ago

/ocabot migration sale_layout_category_hide_detail

Yadier-Tecnativa commented 1 year ago

See the image:

Selección_030

Thanks for the review. For the first problem, I'll have to check what action trigger the create method. and the second, the width is because there are 2 more hidden columns in this state

pedrobaeza commented 1 year ago

I have tried again and now the icons are not clickable. Please ping when all of this is solved.

Yadier-Tecnativa commented 1 year ago

ping @victoralmau , @pedrobaeza

pedrobaeza commented 1 year ago

Almost there. Please move the subtotal when you hide the details to the right:

Selección_043

And please reduce even more the width of each icon column to the minimum needed.

Yadier-Tecnativa commented 1 year ago

Done with css styles

pedrobaeza commented 1 year ago

The width of each icon column is still too narrow.

Yadier-Tecnativa commented 1 year ago

thanks for the review @pedrobaeza ; Added the styles in assets for the 4 different views,(sale orders and invoices) for reports and customer portal

Yadier-Tecnativa commented 1 year ago

ping @pedrobaeza , @CarlosRoca13

Yadier-Tecnativa commented 1 year ago

It's possible to avoid doble clicking on icon to achieve the result?

The rendered widget in section_note needs to have focus to be able to change its value because in this case we added readonly and AllowEdition properties for orders with state != 'draft' which might be colliding with edit mode and Onchange events directly from the Checkout. This condition is logged for improvement in future releases.

pedrobaeza commented 1 year ago

Almost there. The preview of the SO for section with detail hidden is not showing the subtotal:

Selección_075

http://oca-sale-reporting-16-0-pr222-d80e0d12f3ad.runboat.odoo-community.org/web#model=sale.order&id=25&action=377&view_type=form&cids=1

On invoices is working correctly.

Yadier-Tecnativa commented 1 year ago

Fixed up

Yadier-Tecnativa commented 1 year ago

Done!

OCA-git-bot commented 1 year ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

pedrobaeza commented 1 year ago

/ocabot merge nobump

OCA-git-bot commented 1 year ago

What a great day to merge this nice PR. Let's do it! Prepared branch 16.0-ocabot-merge-pr-222-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot commented 1 year ago

Congratulations, your PR was merged at 6978671d4579ebcd705cb4b03f0e15b9eaa8800f. Thanks a lot for contributing to OCA. ❤️