Closed Yadier-Tecnativa closed 1 year ago
/ocabot migration sale_layout_category_hide_detail
See the image:
Thanks for the review. For the first problem, I'll have to check what action trigger the create method. and the second, the width is because there are 2 more hidden columns in this state
I have tried again and now the icons are not clickable. Please ping when all of this is solved.
ping @victoralmau , @pedrobaeza
Almost there. Please move the subtotal when you hide the details to the right:
And please reduce even more the width of each icon column to the minimum needed.
Done with css styles
The width of each icon column is still too narrow.
thanks for the review @pedrobaeza ; Added the styles in assets for the 4 different views,(sale orders and invoices) for reports and customer portal
ping @pedrobaeza , @CarlosRoca13
It's possible to avoid doble clicking on icon to achieve the result?
The rendered widget in section_note needs to have focus to be able to change its value because in this case we added readonly and AllowEdition properties for orders with state != 'draft' which might be colliding with edit mode and Onchange events directly from the Checkout. This condition is logged for improvement in future releases.
Almost there. The preview of the SO for section with detail hidden is not showing the subtotal:
On invoices is working correctly.
Fixed up
Done!
This PR has the approved
label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖
/ocabot merge nobump
What a great day to merge this nice PR. Let's do it! Prepared branch 16.0-ocabot-merge-pr-222-by-pedrobaeza-bump-nobump, awaiting test results.
Congratulations, your PR was merged at 6978671d4579ebcd705cb4b03f0e15b9eaa8800f. Thanks a lot for contributing to OCA. ❤️
@Tecnativa TT43243