search

OCA / sale-reporting

GNU Affero General Public License v3.0
50 stars 193 forks source link

[16.0][IMP] sale_comment_template: allow to use dynamic information in template #227

Closed alan196 closed 1 year ago

alan196 commented 1 year ago

With this change, it allows to define dynamic information from the sale order in the template

alan196 commented 1 year ago

@pedrobaeza thanks for the review 👍

I have updated the requested changes

alan196 commented 1 year ago

@pedrobaeza I just updated the PR to use qweb rendering instead of inline rendering engine, or do you think is better to make a PR to base_comment_template module in order to make qweb rendering the default?

pedrobaeza commented 1 year ago

I think that the syntax should be defined at template level.

OCA-git-bot commented 1 year ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

pedrobaeza commented 1 year ago

/ocabot merge patch

OCA-git-bot commented 1 year ago

What a great day to merge this nice PR. Let's do it! Prepared branch 16.0-ocabot-merge-pr-227-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot commented 1 year ago

Congratulations, your PR was merged at 12204d7c0bd15a560f4b37d38fb9982a14e9e57a. Thanks a lot for contributing to OCA. ❤️