search

OCA / sale-reporting

GNU Affero General Public License v3.0
50 stars 193 forks source link

[ADD] sale_packaging_report: packaging data in sale reports #231

Closed yajo closed 1 year ago

yajo commented 1 year ago

This module displays packaging data (quantity and type) in:

Sale order printed reports: flameshot_2023-09-07_11-47_1

Sale BI reports: flameshot_2023-09-07_11-47

@moduon MT-3773

fcvalgar commented 1 year ago

Tested 👍🏼

For me a small UX/Understangind change. I could ask for more opinions.

"Packaging name: packing_qty"

Actually is:

"(packing_qty Packaging name)"

So I see better:

  • Caja 12: 1.0
  • Pieza: 1.0
  • Caja 2 Paletas: 1.0

imagen

Around report I see this: real sale qty is delivered so could add in the report a second computed measure?

imagen

I think the same about printing the sale order.

Packaging name: packing_qty or any other separator is better.

yajo commented 1 year ago

"Packaging name: packing_qty"

Done.

could add in the report a second computed measure?

Done.

yajo commented 1 year ago

/ocabot merge patch

OCA-git-bot commented 1 year ago

This PR looks fantastic, let's merge it! Prepared branch 16.0-ocabot-merge-pr-231-by-yajo-bump-patch, awaiting test results.

OCA-git-bot commented 1 year ago

@yajo The merge process could not be finalized, because command twine check odoo_addon_sale_packaging_report-16.0.1.0.1-py3-none-any.whl failed with output:

Checking odoo_addon_sale_packaging_report-16.0.1.0.1-py3-none-any.whl: FAILED
ERROR    `long_description` has syntax errors in markup and would not be        
         rendered on PyPI.                                                      
         line 73: Error: Unexpected indentation.                                
WARNING  `long_description_content_type` missing. defaulting to `text/x-rst`.
yajo commented 1 year ago

@sbidoul any clues on how to fix https://github.com/OCA/sale-reporting/pull/231#issuecomment-1713267278?

sbidoul commented 1 year ago

@yajo this looks like a rst syntax error at line 73 of README.rst. Perhaps put line 72 and 73 on a single line?

yajo commented 1 year ago

/ocabot merge patch

OCA-git-bot commented 1 year ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 16.0-ocabot-merge-pr-231-by-yajo-bump-patch, awaiting test results.

OCA-git-bot commented 1 year ago

Congratulations, your PR was merged at 9513d7be605cb19f42f03d8a659976b99e600b01. Thanks a lot for contributing to OCA. ❤️