Closed yajo closed 12 months ago
Tested 👍🏼
For me a small UX/Understangind change. I could ask for more opinions.
"Packaging name: packing_qty"
Actually is:
"(packing_qty Packaging name)"
So I see better:
- Caja 12: 1.0
- Pieza: 1.0
- Caja 2 Paletas: 1.0
Around report I see this: real sale qty is delivered so could add in the report a second computed measure?
I think the same about printing the sale order.
Packaging name: packing_qty or any other separator is better.
"Packaging name: packing_qty"
Done.
could add in the report a second computed measure?
Done.
/ocabot merge patch
This PR looks fantastic, let's merge it! Prepared branch 16.0-ocabot-merge-pr-231-by-yajo-bump-patch, awaiting test results.
@yajo The merge process could not be finalized, because command twine check odoo_addon_sale_packaging_report-16.0.1.0.1-py3-none-any.whl
failed with output:
Checking odoo_addon_sale_packaging_report-16.0.1.0.1-py3-none-any.whl: [31mFAILED[0m
[31mERROR [0m `long_description` has syntax errors in markup and would not be
rendered on PyPI.
line 73: Error: Unexpected indentation.
[33mWARNING [0m `long_description_content_type` missing. defaulting to `text/x-rst`.
@sbidoul any clues on how to fix https://github.com/OCA/sale-reporting/pull/231#issuecomment-1713267278?
@yajo this looks like a rst syntax error at line 73 of README.rst. Perhaps put line 72 and 73 on a single line?
/ocabot merge patch
Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 16.0-ocabot-merge-pr-231-by-yajo-bump-patch, awaiting test results.
Congratulations, your PR was merged at 9513d7be605cb19f42f03d8a659976b99e600b01. Thanks a lot for contributing to OCA. ❤️
This module displays packaging data (quantity and type) in:
Sale order printed reports:![flameshot_2023-09-07_11-47_1](https://github.com/OCA/sale-reporting/assets/973709/d6a2f84f-a8ec-44ab-8d14-de1cb09a748c)
Sale BI reports:![flameshot_2023-09-07_11-47](https://github.com/OCA/sale-reporting/assets/973709/0852869f-118a-4d1e-857b-f4462dde2211)
@moduon MT-3773