search

OCA / sale-reporting

GNU Affero General Public License v3.0
50 stars 193 forks source link

[15.0][IMP] sale_report_delivered_subtotal: Use price_reduce field when price_subtotal is zero #237

Closed carlosdauden closed 1 year ago

carlosdauden commented 1 year ago

@Tecnativa Ping @sergio-teruel @CarlosRoca13

OCA-git-bot commented 1 year ago

Hi @sergio-teruel, some modules you are maintaining are being modified, check this out!

pedrobaeza commented 1 year ago

price_reduce mustn't be used, because it contains the unit price already rounded to the price digits, provoking rounding errors. Talking with Odoo sales dev in latest Odoo XP, they see that this field should be removed for avoiding confusions and I think it has been done in latest versions.

carlosdauden commented 1 year ago

Changes made to use price_reduce only when price cannot be calculated from price_subtotal.

OCA-git-bot commented 1 year ago

@pedrobaeza The merge process could not start, because command git fetch --quiet --force --prune https://github.com/OCA/sale-reporting 'refs/heads/*:refs/heads/*' failed with output:

fatal: unable to access 'https://github.com/OCA/sale-reporting/': gnutls_handshake() failed: The TLS connection was non-properly terminated.
pedrobaeza commented 1 year ago

Please fw-port it to v16.

pedrobaeza commented 1 year ago

/ocabot merge patch

OCA-git-bot commented 1 year ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 15.0-ocabot-merge-pr-237-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot commented 1 year ago

Congratulations, your PR was merged at b904ff029ed641f80eb6e9946ce360b67b7eb14f. Thanks a lot for contributing to OCA. ❤️