search

OCA / sale-reporting

GNU Affero General Public License v3.0
47 stars 187 forks source link

Incompatibility bug of the sale_order_invoice_date module with the POS module #242

Closed majouda closed 2 weeks ago

majouda commented 9 months ago

Module

The name of the module that has a bug. sale_order_invoice_date

Describe the bug

Incompatibility bug of the sale_order_invoice_date module with the POS module

To Reproduce

Affected versions: 14.0

Steps to reproduce the behavior:

  1. Install POS module
  2. Install sale_order_invoice_date, an error will appear

Expected behavior To be able to install the module "sale_order_invoice_date" while POS module is installed

Additional context

The error message: File "/usr/local/lib/python3.8/site-packages/odoo/addons/sale/report/sale_report.py", line 168, in init self.env.cr.execute("""CREATE or REPLACE VIEW %s as (%s)""" % (self._table, self._query())) File "", line 2, in execute File "/usr/local/lib/python3.8/site-packages/odoo/sql_db.py", line 101, in check return f(self, *args, **kwargs) File "/usr/local/lib/python3.8/site-packages/odoo/sql_db.py", line 301, in execute res = self._obj.execute(query, params) Exception

The above exception was the direct cause of the following exception:

Traceback (most recent call last): File "/usr/local/lib/python3.8/site-packages/odoo/http.py", line 652, in _handle_exception return super(JsonRequest, self)._handle_exception(exception) File "/usr/local/lib/python3.8/site-packages/odoo/http.py", line 317, in _handle_exception raise exception.with_traceback(None) from new_cause psycopg2.errors.SyntaxError: each UNION query must have the same number of columns LINE 71: -MIN(l.id) AS id, ^

TumbaoJu commented 8 months ago

@ivantodorovich : Could you please look into this issue. Thank you in advance.

TumbaoJu commented 8 months ago

@simahawk Hello! Can you help with this issue? We would like to know what to do to have it proceeded. Thank you ;)

ivantodorovich commented 8 months ago

Unfortunately, this module is incompatible with the POS.

This is due to the ugly integration of Point of Sale Orders into the Sale Report module done by upstream pos_sale module (ref)

A possible workaround would be to create a "glue" module to implement this "invoice_date" field to data coming from pos orders, or at least add an empty column in its place.

Note that this would happen for any module adding new fields to the Sale Analysis report. It's an architectural flaw

TumbaoJu commented 8 months ago

@ivantodorovich : Thank you for your answer.

github-actions[bot] commented 1 month ago

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.