OCA / sale-reporting

GNU Affero General Public License v3.0
50 stars 193 forks source link

[17.0][MIG] sale_layout_category_hide_detail: Migration to 17.0 #253

Closed jeroenev closed 3 months ago

jeroenev commented 9 months ago

Did you test on a Quote or confirmed SO? buttons are only clickable when the quote is not yet confirmed. This was the same in Odoo16, but I know this was not the case in Odoo14, which might cause some confusion if you know the module from an older Odoo version. Work correctly on this quote: http://oca-sale-reporting-17-0-pr253-e9ff0b161700.runboat.odoo-community.org/web#id=3&cids=1&menu_id=183&action=313&model=sale.order&view_type=form

pedrobaeza commented 9 months ago

/ocabot migration sale_layout_category_hide_detail

willievmobile commented 7 months ago

@jeroenev ive really tried for weeks i cannot get this to work on a odoo17 thats been updated to the version starting this month..? Im desperately needing this to work for the company so we can use odoo17 as without this we have to make 2 quotes for every job. please help?

Ricardoalso commented 5 months ago

@jeroenev ive really tried for weeks i cannot get this to work on a odoo17 thats been updated to the version starting this month..? Im desperately needing this to work for the company so we can use odoo17 as without this we have to make 2 quotes for every job. please help?

Hello @willievmobile, can you give me more context please ?

willievmobile commented 5 months ago

@jeroenev I gave up on this issue and just installed odoo 16 and we are working on that. But basically it looked like it was how the server from Cloudclusters was installed or something. but i just dont know enough to figure it out.

trisdoan commented 5 months ago

@jeroenev I gave up on this issue and just installed odoo 16 and we are working on that. But basically it looked like it was how the server from Cloudclusters was installed or something. but i just dont know enough to figure it out.

Hello @willievmobile, I guess the issue you encountered is 500 Internal Server Error

If yes, I prepared an PR to fix it in https://github.com/jeroenev/sale-reporting/pull/1. Hello @jeroenev, could you plz take this fix into account?

jeroenev commented 5 months ago

@trisdoan any instructions how I would integrate that PR into mine? Not too well versed in the OCA workflows for that

trisdoan commented 5 months ago

Hello @jeroenev, you can go to my PR and merge like this

sample

jeroenev commented 5 months ago

OK that was easier than expected, thanks a lot!

victoralmau commented 5 months ago

Please, cherry-pick https://github.com/OCA/sale-reporting/pull/276 to commit history (before migration commit)

OCA-git-bot commented 5 months ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

arianzaghi commented 5 months ago

@jeroenev Hi! How long is left before the merge?

yvaucher commented 3 months ago

As the PR is ready, we can tackle the FW port of #276 in a later PR.

yvaucher commented 3 months ago

/ocabot merge nobump

OCA-git-bot commented 3 months ago

This PR looks fantastic, let's merge it! Prepared branch 17.0-ocabot-merge-pr-253-by-yvaucher-bump-nobump, awaiting test results.

OCA-git-bot commented 3 months ago

Congratulations, your PR was merged at 339dfec4e1ffc9c8f2f30e79874b1fd266f4f60a. Thanks a lot for contributing to OCA. ❤️