search

OCA / sale-reporting

GNU Affero General Public License v3.0
47 stars 187 forks source link

[14.0][FIX] sale_order_invoice_date: Correct POS Incompatibility #254

Closed majouda closed 5 months ago

majouda commented 5 months ago

This PR is for the issue number #242

OCA-git-bot commented 5 months ago

Hi @ivantodorovich, some modules you are maintaining are being modified, check this out!

majouda commented 5 months ago

Hello @ivantodorovich I don't know why the pre-commit check doesn't pass. Can you please review this PR?

Thank you.

majouda commented 5 months ago

LGTM

As for the pre-commit issue, indeed it seems unrelated to this PR. Perhaps an update from the repo template solves it. Could you try with copier -f update ?

Hello @ivantodorovich I tried to apply copier -f update but it adds a lot of changes I revert the 'Updated from template' commit. Can you please try from your side to update the repository?

Thank you in advance.

ivantodorovich commented 5 months ago

Hello @majouda

I've just created this PR to update the dotfiles from the copier template:

Let's wait until it's approved & merged, and you can rebase your PR afterwards

ivantodorovich commented 5 months ago

You can rebase now

majouda commented 5 months ago

You can rebase now

@ivantodorovich Rebase done. Thank you for your support.

ivantodorovich commented 5 months ago

Thanks for fixing this ❤️

/ocabot merge patch

OCA-git-bot commented 5 months ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 14.0-ocabot-merge-pr-254-by-ivantodorovich-bump-patch, awaiting test results.

OCA-git-bot commented 5 months ago

Congratulations, your PR was merged at fded21450fdc407d63434643e73e3c13bf612014. Thanks a lot for contributing to OCA. ❤️

majouda commented 5 months ago

Thanks for fixing this ❤️

/ocabot merge patch

with pleasure, Thank you @ivantodorovich