[14.0][FIX] sale_layout_category_hide_detail: Full width to note lines

OCA / sale-reporting

GNU Affero General Public License v3.0

47 stars 187 forks source link

[14.0][FIX] sale_layout_category_hide_detail: Full width to note lines #268

Closed victoralmau closed 3 months ago

victoralmau commented 3 months ago

Note type lines do not need to add any logic, they need to maintain full width.

Before antes

After despues

Please @pedrobaeza and @CarlosRoca13 can you review it?

@Tecnativa TT49131

pedrobaeza commented 3 months ago

renderBodyCell is not saying anything. Can you please explain a bit more in the commit message the goal? And doing this is overloading each render with one extra RPC. You should do it on JS on my opinion depending on the display_type.

victoralmau commented 3 months ago

Changed to another approach (updated commit description with before and after examples).

pedrobaeza commented 3 months ago

/ocabot merge patch

OCA-git-bot commented 3 months ago

What a great day to merge this nice PR. Let's do it! Prepared branch 14.0-ocabot-merge-pr-268-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot commented 3 months ago

Congratulations, your PR was merged at a4e989a91631f54ad4ce82c66e09728fff182a46. Thanks a lot for contributing to OCA. ❤️