OCA / sale-reporting

GNU Affero General Public License v3.0
50 stars 193 forks source link

[FIX] [16.0] sale_report_delivered: Consider 0.0 Value valuation layers #271

Closed Shide closed 5 months ago

Shide commented 5 months ago

Take in consideration valuation layers when quantity delivered exceedes demanded quantity.

Why I've changed the subquery line:

Use COALESCE in subselect query to avoid COALESCE in select query

Before

https://www.loom.com/share/4c1b1ef838884b3c8dd3c5a6eed9368b?sid=a7524baa-9feb-46d9-b7a0-4d8f687177a8

MT-6136 @moduon @rafaelbn @Gelojr @fcvalgar please review if you want :)

OCA-git-bot commented 5 months ago

Hi @sergio-teruel, some modules you are maintaining are being modified, check this out!

Shide commented 5 months ago

I would love to have a review of @sergio-teruel before merging

rafaelbn commented 5 months ago

Hello @sergio-teruel ! Good morning 🌅!

We appreciate and consider your opinion here as you are maintainer 🤗

Use COALESCE in subselect query to avoid COALESCE in select query

We have here a BUG and this PR fix it in several scenarios with diferent warehouse configuration, so it looks like more resilient functionality

Let us know!

Thank you! 🙏😃❤️

OCA-git-bot commented 5 months ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot commented 5 months ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 16.0-ocabot-merge-pr-271-by-rafaelbn-bump-patch, awaiting test results.

OCA-git-bot commented 5 months ago

Congratulations, your PR was merged at 8ebba2e36f3616e727a4a76d61236edf507f2c7f. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot commented 5 months ago

It looks like something changed on 16.0 in the meantime. Let me try again (no action is required from you). Prepared branch 16.0-ocabot-merge-pr-271-by-rafaelbn-bump-patch, awaiting test results.

OCA-git-bot commented 5 months ago

Congratulations, your PR was merged at 8ebba2e36f3616e727a4a76d61236edf507f2c7f. Thanks a lot for contributing to OCA. ❤️