search

OCA / sale-reporting

GNU Affero General Public License v3.0
50 stars 193 forks source link

[17.0][MIG] sale_order_report_product_image: Migration to 17.0 #283

Closed JoseIbarraHdz closed 2 months ago

JoseIbarraHdz commented 2 months ago

image

edy1192 commented 2 months ago

Functional test LGTM 👍🏼

edy1192 commented 2 months ago

Hi @manuelregidor could you check this, please?

cc @JoseIbarraHdz

manuelregidor commented 2 months ago

@edy1192 You need to have two commits: one for the pre-commit auto fixes and another one for the migration itself.

JoseIbarraHdz commented 2 months ago

Hi @manuelregidor could you check this please? There are the two commits you mentioned above.

Regards.

cc. @edy1192

OCA-git-bot commented 2 months ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

JoseIbarraHdz commented 2 months ago

Hi @pedrobaeza I did the changes you requested, can you please check?

JoseIbarraHdz commented 2 months ago

Hi @pedrobaeza thanks for the approval, I'll follow the guide steps next time, by the way, it is already merged?

Regards.

pedrobaeza commented 2 months ago

/ocabot merge nobump

OCA-git-bot commented 2 months ago

What a great day to merge this nice PR. Let's do it! Prepared branch 17.0-ocabot-merge-pr-283-by-pedrobaeza-bump-nobump, awaiting test results.

pedrobaeza commented 2 months ago

/ocabot migration sale_order_report_product_image

OCA-git-bot commented 2 months ago

Congratulations, your PR was merged at d3d061340e6e2f7338af6dac8978489abd9afa05. Thanks a lot for contributing to OCA. ❤️