OCA-git-bot commented 3 years ago

Todo

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-14.0

Modules to migrate

[x] portal_sale_personal_data_only - By @victoralmau - #1721
[ ] product_form_sale_link - #1722
[x] product_supplierinfo_for_customer_elaboration - By @CarlosRoca13 - #2205
[x] product_supplierinfo_for_customer_sale - By @LoisRForgeFlow - #1680
[x] sale_automatic_workflow - By @phuctranerp - #1397
[x] sale_automatic_workflow_job - By @hailangvn - #1868
[ ] sale_automatic_workflow_payment
[x] sale_blanket_order - By @tafaRU - #1865
[ ] sale_by_packaging
[x] sale_cancel_reason - By @ao-landoo - #2158
[x] sale_commercial_partner - By @newtratip - #1309
[x] sale_company_currency - By @alexeirivera87 - #1934
[x] sale_contact_type - By @LudLaf - #2010
[ ] sale_cutoff_time_delivery - By @phuctranerp - #1403
[x] sale_delivery_state - By @PierrickBrun - #1372
[ ] sale_double_validation - By @simoneversienti - #1682
[x] sale_discount_display_amount - By @chafique-delli - #1288
[x] sale_elaboration - By @CarlosRoca13 - #2203
[x] sale_exception - By @damdam-s - #1571
[x] sale_exception_product_sale_manufactured_for - By @sonhd91 - #1761
[x] sale_fixed_discount - By @damdam-s - #2507
[x] sale_force_invoiced - By @MateuGForgeFlow - #1569
[ ] sale_generator - By @yweng8111 - #1976
[x] sale_global_discount - By @omar7r - #1699
[ ] sale_invoice_auto_deliver - By @xavier-bouquiaux - #1579
[x] sale_invoice_no_mail - By @SilvioC2C - #2117
[ ] sale_invoice_plan - By @johnho91 - #1406
[ ] sale_invoice_policy - By @damdam-s - #1762
[x] sale_last_price_info - By @newtratip - #1311
[x] sale_mrp_bom - By @hailangvn - #1558
[x] sale_order_amount_to_invoice - By @toita86 - #2993
[x] sale_order_archive - By @astirpe - #1298
[x] sale_order_carrier_auto_assign - By @phuctranerp - #1412
[ ] sale_order_digitized_signature - By @Freni-OSI - #1624
[x] sale_order_invoicing_finished_task - By @ernestotejeda - #1924
[x] sale_order_line_input - By @bealdav - #1837
[x] sale_order_line_sequence - By @MiquelRForgeFlow - #2104
[x] sale_order_mass_action - By @rousseldenis - #1897
[x] sale_order_price_recalculation - By @JasminSForgeFlow - #2136
[x] sale_order_priority - By @GuillemCForgeFlow - #1783
[x] sale_order_product_assortment - By @ilyasProgrammer - #2067
[ ] sale_order_product_recommendation - By @dani-xtendoo - #2682
[ ] sale_order_product_recommendation_secondary_unit - By @dzungtran89 - #1778
[x] sale_order_qty_change_no_recompute - By @victoralmau - #1592
[x] sale_order_line_date - By @cor9003 - #1460
[ ] sale_order_line_packaging_qty - By @estekadigital - #1611
[x] sale_order_line_price_history - By @dsolanki-initos - #1620
[ ] sale_order_line_sequence
[x] sale_order_lot_selection - By @florian-dacosta - #1360
[ ] sale_order_product_availability_inline
[ ] sale_order_product_recommendation - By @ShivamS-SerpentCS - #1540
[ ] sale_order_product_recommendation_secondary_unit
[ ] sale_order_restrict_cancel_existing_invoice - By @xavier-bouquiaux - #1581
[x] sale_order_revision - By @kittiu - #1369
[x] sale_order_secondary_unit - By @Kev-Roche - #1671
[ ] sale_order_transmit_method - By @joshburkholder - #2320
[x] sale_order_type - ~~By @newtratip - #1425~~ By @BT-cserra - #1646
[ ] sale_partner_cutoff_delivery_window - By @dzungtran89 - #1414
[x] sale_partner_incoterm - By @ReedHayashikawa - #1394
[ ] sale_pricelist_triple_discount - By @are-agilebg - #2121
[x] sale_procurement_amendment - By @rousseldenis - #1574
[ ] sale_procurement_group_by_commitment_date - By @JuanyDForgeflow - #2029
[x] sale_procurement_group_by_line - By @fredzamoabg - #1689
[x] sale_product_category_menu - By @newtratip - #1310
[x] sale_product_multi_add - By @newtratip - #1334
[x] sale_product_set - @phuctranerp - #1399
[ ] sale_product_set_layout - By @rousseldenis - #1839
[x] sale_product_set_packaging_qty - By @phuctranerp - #1402
[x] sale_product_set_sale_by_packaging - By @sonhd91 - #1738
[ ] sale_promotion_rule - By @xavier-bouquiaux - #1583
[ ] sale_promotion_rule_delivery - By @xavier-bouquiaux - #2069
[ ] sale_promotion_rule_display_discount_amount - By @xavier-bouquiaux - #1586
[x] sale_quotation_number - By @Vanneri - #1350
[ ] sale_require_po_doc - By @ChrisOForgeFlow - #2494
[x] sale_restricted_qty - By @AshishHirapara - #1961
[ ] sale_shipping_info_helper
[ ] sale_sourced_by_line - By @murtuzasaleh - #1612
[x] sale_stock_delivery_address - By @BernatPForgeFlow - #1833
[x] sale_stock_line_sequence - By @OriolMForgeFlow - #2607
[x] sale_stock_picking_note - ~~By @acsonefho - #1652~~ By @victoralmau - #1769
[x] sale_stock_return_request - By @dalonsod - #2713
[x] sale_stock_secondary_unit - By @toita86 - #2761
[x] sale_tier_validation - By @aphon61bank - #1455
[x] sale_triple_discount - By @ferran-73 - #1727
[x] sale_validity - By @newtratip - #1314
[x] sale_wishlist - By @phuctranerp - #1401
[x] sales_team_security - By @ivantodorovich - #1352

Missing module? Check https://github.com/OCA/maintainer-tools/wiki/%5BFAQ%5D-Missing-modules-in-migration-issue-list

chafique-delli commented 3 years ago

sale_discount_display_amount here https://github.com/OCA/sale-workflow/pull/1288

newtratip commented 3 years ago

sale_commercial_partner https://github.com/OCA/sale-workflow/pull/1309

newtratip commented 3 years ago

sale_product_category_menu https://github.com/OCA/sale-workflow/pull/1310

newtratip commented 3 years ago

sale_last_price_info https://github.com/OCA/sale-workflow/pull/1311

newtratip commented 3 years ago

sale_validity https://github.com/OCA/sale-workflow/pull/1314

newtratip commented 3 years ago

sale_product_multi_add https://github.com/OCA/sale-workflow/pull/1334

JSeguiN97 commented 3 years ago

sale_elaboration #1341

Vanneri commented 3 years ago

sale_quotation_number #1350

ivantodorovich commented 3 years ago

sales_team_security: https://github.com/OCA/sale-workflow/pull/1352

florian-dacosta commented 3 years ago

sale_order_lot_selection https://github.com/OCA/sale-workflow/pull/1360

kittiu commented 3 years ago

Hi, I would like to make migration to sale_order_revision but in the way that split it to,

base_revision (server-ux ??)
sale_order_revision (here, as extension).

I need similar capability used in other module, DRY.

Is this doable, WDYT? @rafaelbn @pedrobaeza @rousseldenis cc @newtratip

pedrobaeza commented 3 years ago

Do you think there's is too much logic to share? I don't see it, as most is dependent on the name of the fields and UI stuff that can't be shared (but I don't remember in detail).

kittiu commented 3 years ago

Do you think there's is too much logic to share? I don't see it, as most is dependent on the name of the fields and UI stuff that can't be shared (but I don't remember in detail).

I think it is much enough. https://github.com/OCA/sale-workflow/blob/13.0/sale_order_revision/models/sale_order.py I think almost all the code can be on base_revision. As we plan to do the same for many models, I think it is good amount of code. In our case, sale, purchase, budget plan, contract, agreement...

But I worry about migration from 13 to 14, not sure how to deal with migration script.

pedrobaeza commented 3 years ago

OK, go ahead with OCA/server-ux. There's no need of migration scripts, as the new dependency will add to the "to install" list automatically.

kittiu commented 3 years ago