[17.0][MIG] sale_triple_discount

OCA / sale-workflow

Odoo Sales, Workflow and Organization

GNU Affero General Public License v3.0

297 stars 1.03k forks source link

[17.0][MIG] sale_triple_discount #3406

Open dalonsod opened 2 weeks ago

dalonsod commented 2 weeks ago

Standard migration.

Supersedes #3157 due to inactivity.

Pending tasks:

[ ] Depends on https://github.com/OCA/account-invoicing/pull/1626
[ ] Add https://github.com/OCA/sale-workflow/pull/2885 when merged in v16
[ ] Squash adminstrative commits

rousseldenis commented 1 week ago

/ocabot migration sale_triple_discount

ferran-S73 commented 16 hours ago

@dalonsod your pre-commit commit is modifying files from another module, is this intended? I think you should this, please remove these changes

dalonsod commented 15 hours ago

@ferran-S73 these changes (for addon sale_order_general_discount) were automatically added by pre-commit execution, I didn't notice it. It suggests that sale_order_general_discount doesn't fit current pre-commit standard. I can remove it without any problem for this PR, but IMO this should be permanently fixed in that addon anyway.

ferran-S73 commented 15 hours ago

@ferran-S73 these changes (for addon sale_order_general_discount) were automatically added by pre-commit execution, I didn't notice it. It suggests that sale_order_general_discount doesn't fit current pre-commit standard. I can remove it without any problem for this PR, but IMO this should be permanently fixed in that addon anyway.

@dalonsod I agree it should be fixed if it needs fixing but I don't think it should be done in this PR and in the same commit as the changes from the module you are migrating

dalonsod commented 7 hours ago

@ferran-S73 done