OCA / search-engine

GNU Affero General Public License v3.0
46 stars 61 forks source link

[14.0] [IMP] connector_search_engine: Use real recompute_json batches with dichotomic retry on fail #102

Closed paradoxxxzero closed 1 year ago

paradoxxxzero commented 3 years ago

This PR batches the recompute_json jobs together instead of batching the job creation. It also adds a dichotomic retry on failing batches, which is nice to quickly isolate failing bindings.

Superseeds #100

@sebastienbeau

hparfr commented 3 years ago

@paradoxxxzero can you please fix this PR ?

simahawk commented 2 years ago

Is this work finished? Also, I wonder if we shouldn't leverage identity_key to avoid duplication of jobs.

github-actions[bot] commented 2 years ago

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

sebastienbeau commented 2 years ago

@paradoxxxzero, great work, minor comment to change We should merge it next week

paradoxxxzero commented 2 years ago

@sebastienbeau I merged your changes and rebased

sebastienbeau commented 2 years ago

@simahawk used in production, are you ok for merging it ?

sebastienbeau commented 2 years ago

@simahawk done ! thanks for your feedback

sebastienbeau commented 1 year ago

@simahawk can you review?

simahawk commented 1 year ago

I'll have a look today :sweat_smile:

simahawk commented 1 year ago

We need this to fix pre-commit https://github.com/OCA/search-engine/pull/137

simahawk commented 1 year ago

@paradoxxxzero can you rebase?

simahawk commented 1 year ago

/ocabot merge minor

OCA-git-bot commented 1 year ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 14.0-ocabot-merge-pr-102-by-simahawk-bump-minor, awaiting test results.

OCA-git-bot commented 1 year ago

Congratulations, your PR was merged at 82f4d0a7a154dff7ce7537691b5761cdb91ce6c8. Thanks a lot for contributing to OCA. ❤️