Closed paradoxxxzero closed 1 year ago
@paradoxxxzero can you please fix this PR ?
Is this work finished?
Also, I wonder if we shouldn't leverage identity_key
to avoid duplication of jobs.
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.
@paradoxxxzero, great work, minor comment to change We should merge it next week
@sebastienbeau I merged your changes and rebased
@simahawk used in production, are you ok for merging it ?
@simahawk done ! thanks for your feedback
@simahawk can you review?
I'll have a look today :sweat_smile:
We need this to fix pre-commit https://github.com/OCA/search-engine/pull/137
@paradoxxxzero can you rebase?
/ocabot merge minor
Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 14.0-ocabot-merge-pr-102-by-simahawk-bump-minor, awaiting test results.
Congratulations, your PR was merged at 82f4d0a7a154dff7ce7537691b5761cdb91ce6c8. Thanks a lot for contributing to OCA. ❤️
This PR batches the
recompute_json
jobs together instead of batching the job creation. It also adds a dichotomic retry on failing batches, which is nice to quickly isolate failing bindings.Superseeds #100
@sebastienbeau