OCA / search-engine

GNU Affero General Public License v3.0
46 stars 61 forks source link

[FIX] connector_search_engine: not possible to edit index lines #140

Closed acsonefho closed 1 year ago

acsonefho commented 1 year ago

Tree view (into backend) who displays indexes remove backend_id (invisible field) so not possible to edit a line (to update the exporter_id for example). Removing this no-visible field solve the issue.

xavier-bouquiaux commented 1 year ago

LGTM

github-actions[bot] commented 1 year ago

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

acsonefho commented 1 year ago

@OCA/search-engine-maintainers Can you review and merge please? Easy quick and old fix.

simahawk commented 1 year ago

@acsonefho Seems legit. One small request: can you please rewrite the commit msg? The explanation is not meant to stay in the short msg itself, it goes into the commit description. Our ref: https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#commit-message

Example that you can copy / paste if you like:

[FIX] connector_search_engine: fix se.index edit

Since the field was hidden it was not possible to edit a line (to update the exporter for example).
Removing this no-visible field solves the issue.
simahawk commented 1 year ago

@acsonefho Seems legit. One small request: can you please rewrite the commit msg? The explanation is not meant to stay in the short msg itself, it goes into the commit description. Our ref: https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#commit-message

Example that you can copy / paste if you like:

[FIX] connector_search_engine: fix se.index edit

Since the field was hidden it was not possible to edit a line (to update the exporter for example).
Removing this no-visible field solves the issue.

Note: I'm not blocking, if you are in a rush we can merge as-is. Still, if you have time please do it :pray:

acsonefho commented 1 year ago

@simahawk Thank you for your feedback. I edit the commit :)

simahawk commented 1 year ago

/ocabot merge patch

acsonefho commented 1 year ago

/ocabot merge patch

@simahawk I think the command doesn't work

HviorForgeFlow commented 1 year ago

Sometimes ocabot has this behavior, from my experience it will work at some point during the day :smile:

simahawk commented 1 year ago

/ocabot merge patch

OCA-git-bot commented 1 year ago

On my way to merge this fine PR! Prepared branch 14.0-ocabot-merge-pr-140-by-simahawk-bump-patch, awaiting test results.

OCA-git-bot commented 1 year ago

This PR looks fantastic, let's merge it! Prepared branch 14.0-ocabot-merge-pr-140-by-simahawk-bump-patch, awaiting test results.

OCA-git-bot commented 1 year ago

Congratulations, your PR was merged at 44c63410a44a0ff5f38d8bcfab962995645c0392. Thanks a lot for contributing to OCA. ❤️