Closed acsonefho closed 1 year ago
LGTM
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.
@OCA/search-engine-maintainers Can you review and merge please? Easy quick and old fix.
@acsonefho Seems legit. One small request: can you please rewrite the commit msg? The explanation is not meant to stay in the short msg itself, it goes into the commit description. Our ref: https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#commit-message
Example that you can copy / paste if you like:
[FIX] connector_search_engine: fix se.index edit
Since the field was hidden it was not possible to edit a line (to update the exporter for example).
Removing this no-visible field solves the issue.
@acsonefho Seems legit. One small request: can you please rewrite the commit msg? The explanation is not meant to stay in the short msg itself, it goes into the commit description. Our ref: https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#commit-message
Example that you can copy / paste if you like:
[FIX] connector_search_engine: fix se.index edit Since the field was hidden it was not possible to edit a line (to update the exporter for example). Removing this no-visible field solves the issue.
Note: I'm not blocking, if you are in a rush we can merge as-is. Still, if you have time please do it :pray:
@simahawk Thank you for your feedback. I edit the commit :)
/ocabot merge patch
/ocabot merge patch
@simahawk I think the command doesn't work
Sometimes ocabot has this behavior, from my experience it will work at some point during the day :smile:
/ocabot merge patch
On my way to merge this fine PR! Prepared branch 14.0-ocabot-merge-pr-140-by-simahawk-bump-patch, awaiting test results.
This PR looks fantastic, let's merge it! Prepared branch 14.0-ocabot-merge-pr-140-by-simahawk-bump-patch, awaiting test results.
Congratulations, your PR was merged at 44c63410a44a0ff5f38d8bcfab962995645c0392. Thanks a lot for contributing to OCA. ❤️
Tree view (into backend) who displays indexes remove
backend_id
(invisible field) so not possible to edit a line (to update theexporter_id
for example). Removing this no-visible field solve the issue.