[16.0][FIX] connector_search_engine: add compatibility for python <3.10

OCA / search-engine

GNU Affero General Public License v3.0

45 stars 60 forks source link

[16.0][FIX] connector_search_engine: add compatibility for python <3.10 #160

Closed JordiBForgeFlow closed 6 months ago

JordiBForgeFlow commented 11 months ago

The union of types using the | syntax was introduced in Python 3.10, and it's not valid in Python 3.8. We get an error during installation of the module. @lmignon I am not sure if I fixed entirely.

lmignon commented 11 months ago

@JordiBForgeFlow Do you know that even on runbot, Odoo 16 is running on py 3.10? I'm not against this change but it will be an endless battle since the CI also runs on 3.10 and this kind of error will never be detected before someone try to use the module on an older version.

Regards.

github-actions[bot] commented 7 months ago

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.