search

OCA / search-engine

GNU Affero General Public License v3.0
46 stars 61 forks source link

[16.0] search_engine_image_thumbnail: New config param #176

Closed lmignon closed 7 months ago

lmignon commented 11 months ago

Add new config parameter on the search engine backend to allow the user to specify if the serialization of a record should fail if thumbnails are requested but no thumbnail sizes are defined for the model and field for which it' requested. Defaults to False (i.e. don't fail).

lmignon commented 11 months ago

@qgroulard @sbejaoui @sebastienbeau

lmignon commented 11 months ago

/ocabot merge patch

OCA-git-bot commented 11 months ago

What a great day to merge this nice PR. Let's do it! Prepared branch 16.0-ocabot-merge-pr-176-by-lmignon-bump-patch, awaiting test results.

OCA-git-bot commented 11 months ago

@lmignon The merge process could not be finalized, because command oca-gen-addon-readme --if-source-changed --org-name OCA --repo-name search-engine --branch 16.0 --addons-dir /tmp/tmpl8tgn5yz --commit failed with output:

Both .md and .rst fragments found in /tmp/tmpl8tgn5yz/search_engine_image_thumbnail/readme. Please ensure the same format is used for all fragments.
lmignon commented 7 months ago

/ocabot merge patch

OCA-git-bot commented 7 months ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 16.0-ocabot-merge-pr-176-by-lmignon-bump-patch, awaiting test results.

OCA-git-bot commented 7 months ago

@lmignon The merge process could not be finalized, because command oca-gen-addon-readme --if-source-changed --org-name OCA --repo-name search-engine --branch 16.0 --addons-dir /tmp/tmp4d_omngx --commit failed with output:

Both .md and .rst fragments found in /tmp/tmp4d_omngx/search_engine_image_thumbnail/readme. Please ensure the same format is used for all fragments.
lmignon commented 7 months ago

/ocabot merge patch

OCA-git-bot commented 7 months ago

@lmignon The merge process could not start, because command `git merge --no-ff -m 'Merge PR #176 into 16.0

Signed-off-by lmignon' tmp-pr-176` failed with output:

Auto-merging search_engine_image_thumbnail/static/description/index.html
CONFLICT (content): Merge conflict in search_engine_image_thumbnail/static/description/index.html
Auto-merging search_engine_image_thumbnail/README.rst
CONFLICT (content): Merge conflict in search_engine_image_thumbnail/README.rst
Automatic merge failed; fix conflicts and then commit the result.
lmignon commented 7 months ago

/ocabot merge patch

OCA-git-bot commented 7 months ago

On my way to merge this fine PR! Prepared branch 16.0-ocabot-merge-pr-176-by-lmignon-bump-patch, awaiting test results.

OCA-git-bot commented 7 months ago

Congratulations, your PR was merged at 5eb57827b079e79ffca346ddc29c5caf7d0768f4. Thanks a lot for contributing to OCA. ❤️