Closed clementmbr closed 4 months ago
Thanks for this fix I don't know if the lib has to be added manually in requirement file, because it say it is "generated from manifests external_dependencies".
I am not sure though and I guess it won't hurt.
Pre-commit does the job for you if you add a dependency in manifest
I don't know if the lib has to be added manually in requirement file, because it say it is "generated from manifests external_dependencies".
I didn't run pre-commit on my local branch, so I had to add the lib to the requirements manually as the pre-commit test went red here.
Anyway, @OCA/search-engine-maintainers is it possible to merge this trivial PR? Thanks!
/ocabot merge patch
On my way to merge this fine PR! Prepared branch 16.0-ocabot-merge-pr-194-by-rvalyi-bump-patch, awaiting test results.
Congratulations, your PR was merged at e3585ba1800cf50e6365b616ebf4c77f7625ffd3. Thanks a lot for contributing to OCA. ❤️
Trivial PR to fix this kind of bug in CI: https://github.com/OCA/sale-channel/actions/runs/8332403108/job/22801435634?pr=17#step:7:446
This bug doesn't occur on search-engine repo because the module
search_engine_serializer_pydantic
usepydantic
which depends on python packagetyping-extensions
. So typing-extensions is loaded anyway.But when a module on another repo like
sale_channel
needs to useconnector_search_engine
without usingsearch_engine_serializer_pydantic
, the bug occurs.Once this PR is merged I will be able to merge https://github.com/OCA/sale-channel/pull/17
cc @florian-dacosta @bealdav @rousseldenis @adrienpeiffer