search

OCA / server-auth

https://odoo-community.org/psc-teams/tools-30
GNU Affero General Public License v3.0
150 stars 404 forks source link

[16.0][IMP] auth_session_timeout adapt to use websocket instead of longpolling #555

Open bosd opened 11 months ago

bosd commented 11 months ago

Migration leftover see: https://github.com/OCA/server-auth/pull/507#pullrequestreview-1603549270

github-actions[bot] commented 7 months ago

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

thomaspaulb commented 7 months ago

/ocabot rebase

OCA-git-bot commented 7 months ago

Congratulations, PR rebased to 16.0.

thomaspaulb commented 7 months ago

@bosd Any reason why this was still on draft? Otherwise I will just merge, since it should have been part of https://github.com/OCA/server-auth/pull/507

bosd commented 7 months ago

Any reason why this was still on draft?

It's been a while. Actually I don't remember. :) Likely I was not sure of these changes.

In general I think the tests of this module needs to be changed. As before the module was not working. Yet tests where still passing.

thomaspaulb commented 6 months ago

Hm, I looked into it for a bit and in 16.0, /bus/im_status does not exist, rather things seem to go through a websocket, and as such they are not regular polling calls, but persistent websocket connections through which data can flow.

Hence I'm not even sure if "ignored_urls" are needed at all.

If we wanted to add a unit test, one ideais to do a naive "tour" test - open a headless Chrome browser, set timeout to 1 minute, do nothing but let any browser background calls do their thing, then check whether session has indeed timed out, or if it has been woken up by some websocket call.

Of course we could actively simulate such websocket calls as well, that's another option.

As for functional experience - are you using this somewhere in production, and does it work?

bosd commented 6 months ago

As for functional experience - are you using this somewhere in production, and does it work?

Well, I know a few places where it is installed in production. But I'm currently not associated with that partner.

Side note: Currently in the process of becoming an offical partner.

Long time ago I did a successfull functional test "Manually" on V16.