Closed tb-flyt closed 3 months ago
The last commit message should be renamed [FIX] auth_saml: relay state may be empty
.
Squash the last two commits with the migration.
Note that they do not respect the expected format for OCA’s commit message; Odoo’s guidelines are used.
Thanks for porting this. Could you cherry pick these commits: https://github.com/OCA/server-auth/pull/600
@tb-flyt are you still working on this?
Hi
Not really, I fixed the problem for the customer but did not have the stamina or competence to fix the PR so it could be accepted.
-Torvald
Frå: Cas Vissers @.> Sendt: måndag 18. mars 2024 11:18 Til: OCA/server-auth @.> Kopi: Torvald Bringsvor @.>; Mention @.> Emne: Re: [OCA/server-auth] [17.0][MIG] auth_saml: Migration to 17.0 (PR #586)
@tb-flythttps://github.com/tb-flyt are you still working on this?
— Reply to this email directly, view it on GitHubhttps://github.com/OCA/server-auth/pull/586#issuecomment-2003474983, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BEMN44QL5VWFYWD6CVFROA3YY25RDAVCNFSM6AAAAABAWMQW5CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBTGQ3TIOJYGM. You are receiving this because you were mentioned.Message ID: @.***>
In https://github.com/OCA/server-auth/pull/634 I recreated a PR containing the latest V16 commits and some code adjustments to avoid the pre-commit deleting the "import Set"
This PR can be closed; #634 replaces it (which should be merged in).
superseeded by #634
/ocabot migration auth_saml