[14.0][FIX] auth_saml: password reset when deactivating the config settings

OCA / server-auth

https://odoo-community.org/psc-teams/tools-30

GNU Affero General Public License v3.0

150 stars 403 forks source link

[14.0][FIX] auth_saml: password reset when deactivating the config settings #599

Closed leemannd closed 8 months ago

leemannd commented 8 months ago

issue

have users with password
install the module auth_saml
activate the paramter that allows to login with the password
setup of the user with the saml provider
update the settings by removing the possibility to log with the password

This will delete the ir.config parameter, but not trigger the removal of the password.

Fix Now when we update the settings and unlink the related ir.config.parameter. We trigger the removal of passwords

Once this PR is merged, I'll forward port it to next versions

leemannd commented 8 months ago

Hello @vincent-hatakeyama as you recently worked on this module, do you have time for a review and eventually a merge?

OCA-git-bot commented 8 months ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

vincent-hatakeyama commented 8 months ago

/ocabot merge patch

OCA-git-bot commented 8 months ago

On my way to merge this fine PR! Prepared branch 14.0-ocabot-merge-pr-599-by-vincent-hatakeyama-bump-patch, awaiting test results.

OCA-git-bot commented 8 months ago

Congratulations, your PR was merged at 3209739bbbeb8aee418223babcd5ab3f0acd0360. Thanks a lot for contributing to OCA. ❤️