[MIG][16.0] Migration of vault_share

OCA / server-auth

https://odoo-community.org/psc-teams/tools-30

GNU Affero General Public License v3.0

155 stars 416 forks source link

[MIG][16.0] Migration of vault_share #612

Closed fkantelberg closed 7 months ago

fkantelberg commented 8 months ago

Based on #611

The migration needed quite a rework because of the JS framework changes. (I hope the next are easier) I tested every functionality during migration but plan to do another round again soon.

There are some minor fixes which were possible to do:

Creating shares is now possible using the views
Better file handling. Inside of an entry you can share now

pedrobaeza commented 8 months ago

/ocabot migration vault_share

CarlosRoca13 commented 8 months ago

Please rebase to get changes :)

pedrobaeza commented 7 months ago

@fkantelberg this one doesn't contain commit history. Please preserve it for also analyzing the specific changes done for 16.0

fkantelberg commented 7 months ago

Yes I haven't used format-patch again and the commits were shared between the vault and vault_share PR. Was weird and I re-did the entire process.

pedrobaeza commented 7 months ago

Let's not be more picky asking to squash this last commit, but there's no advantage in GitHub putting separate commits for new additions in a PR, and the commit history is a bit worse having them split.

/ocabot merge nobump

OCA-git-bot commented 7 months ago

What a great day to merge this nice PR. Let's do it! Prepared branch 16.0-ocabot-merge-pr-612-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot commented 7 months ago

Congratulations, your PR was merged at 41bab0e638b3f4830ccff2d96c1ecf5672b5670f. Thanks a lot for contributing to OCA. ❤️