search

OCA / server-auth

https://odoo-community.org/psc-teams/tools-30
GNU Affero General Public License v3.0
146 stars 399 forks source link

[FIX][14.0] auth_saml: readme an link to the runboat #623

Closed leemannd closed 1 month ago

leemannd commented 4 months ago

These changes where introduced with the backport of the refactoring of the module auth_saml in -> https://github.com/OCA/server-auth/commit/cd6082aef3150d089317795a53a057d4452aeaf7

In this PR I change them back to values related to 14.0 for more consistency

leemannd commented 4 months ago

Hello @vincent-hatakeyama Can you have a look at this README and runboat link update?

vincent-hatakeyama commented 3 months ago

Those files are automatically updated by the runbot.

For the information about the changes, you need to edit readme/HISTORY.rst that is used by the runbot.

vincent-hatakeyama commented 3 months ago

@OCA/tools-maintainers The author of this PR tries to fix the index.html file directly but that file is supposed to be generated automatically. The README of the 14.0 branch is correct but auth_saml/ references the 15.0 branch. Is there a way to force the bot to do the update?

dreispt commented 3 months ago

@vincent-hatakeyama Something went wrong there. Recent version of pre-commit ensure the README is generated.

dreispt commented 3 months ago

/ocabot merge patch

OCA-git-bot commented 3 months ago

This PR looks fantastic, let's merge it! Prepared branch 14.0-ocabot-merge-pr-623-by-dreispt-bump-patch, awaiting test results.

OCA-git-bot commented 3 months ago

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-623-by-dreispt-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

OCA-git-bot commented 3 months ago

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-623-by-dreispt-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

thomaspaulb commented 3 months ago

@dreispt @pedrobaeza Should we maybe do a manual merge in this situation? It's just readme updates so there's no harm done

hbrunn commented 3 months ago

seems to me you fell victim of https://github.com/OCA/oca-addons-repo-template/issues/250#issuecomment-2084674256 - retry?

/ocabot merge patch

OCA-git-bot commented 3 months ago

On my way to merge this fine PR! Prepared branch 14.0-ocabot-merge-pr-623-by-hbrunn-bump-patch, awaiting test results.

OCA-git-bot commented 3 months ago

@hbrunn your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-623-by-hbrunn-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

pedrobaeza commented 3 months ago

You have to wait until the situation with Codecov is resolved.

leemannd commented 1 month ago

Closing as old and outdated