search

OCA / server-auth

https://odoo-community.org/psc-teams/tools-30
GNU Affero General Public License v3.0
146 stars 399 forks source link

[17.0][ADD] new module auth_admin_passkey_totp_mail_enforce #625

Open astirpe opened 4 months ago

astirpe commented 4 months ago

Depends on https://github.com/OCA/server-auth/pull/624

Context In https://github.com/OCA/server-auth/pull/550 (V16) and https://github.com/OCA/server-auth/pull/624 (V17) there's a proposal for module auth_admin_passkey to bypass TOTP/2FA for admin passkey. In case module auth_totp_mail_enforce is also installed, the above solution may not work, depending on which module was installed in which order (first or second).

Proposal We hereby propose this glue module, auto-installable in case both auth_admin_passkey auth_totp_mail_enforce are installed. This module ensures that method _mfa_url() is executed properly, regardless of which of the modules (auth_admin_passkey or auth_totp_mail_enforce) was installed first.

astirpe commented 4 months ago

@legalsylvain done, could you check?

github-actions[bot] commented 3 weeks ago

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.