search

OCA / server-auth

https://odoo-community.org/psc-teams/tools-30
GNU Affero General Public License v3.0
146 stars 399 forks source link

[16.0][FIX] vault: Secret generator is not saving new value #663

Closed CarlosRoca13 closed 1 month ago

CarlosRoca13 commented 1 month ago

When a field has assigned a value and we try to change it by using the secrets generator, the new value is not saved. It is happening because the click event on wizard buttons is propagated and this trigger the bus event RELATIONAL_MODEL:NEED_LOCAL_CHANGES.

By doing this changes the value generated is assigned to the field without loosing the focus. So the value is saved.

Steps to reproduce the problem:

  1. Create a Vault
  2. Create an Entry for the Vault
  3. Create a Field for the Entry
  4. Assign a value
  5. Edit the value using the button to generate secrets
  6. Save the new secret

You will see that the value salected on wizard is not saved.

cc @Tecnativa TT49554

ping @victoralmau @pedrobaeza @fkantelberg

pedrobaeza commented 1 month ago

/ocabot merge patch

OCA-git-bot commented 1 month ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 16.0-ocabot-merge-pr-663-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot commented 1 month ago

Congratulations, your PR was merged at caf6a8922e25e359dfc61d01383e34dca9cf0d47. Thanks a lot for contributing to OCA. ❤️